Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreDNS middleware? #15

Open
miekg opened this issue Oct 18, 2016 · 4 comments
Open

CoreDNS middleware? #15

miekg opened this issue Oct 18, 2016 · 4 comments
Labels

Comments

@miekg
Copy link

miekg commented Oct 18, 2016

This is more a feature request.

Would you be willing to port this over to a CoreDNS middleware?

I think it would be awesome to include this (somehow) in the existing proxy middleware. Not sure how much work that would be though.

Also re-resolving dns.google.com every so often is an interesting problem.

@pforemski
Copy link
Owner

Hi @miekg. First of all, thanks for your great dns library, which dingo is using. Please find my initial response below, just to start discussion.

Having looked at CoreDNS and some of the middleware implementations, how do you think dingo could be "ported over" to CoreDNS? In particular, I wouldn't be willing to convert dingo to a plugin, I want to remain it as a standalone project (eg. due to simplicity & compiled binary size).

So, maybe an option to go would be to make it possible to use dingo as a Go library? Besides, why just using the "proxy" CoreDNS middleware pointed at dingo running on loopback wouldn't be sufficient?

@pforemski pforemski added the idea label Oct 19, 2016
@miekg
Copy link
Author

miekg commented Oct 19, 2016

[ Quoting [email protected] in "Re: [pforemski/dingo] CoreDNS middl..." ]

Hi @miekg. First of all, thanks for your great dns library, which dingo is using. Please find my initial response below, just to start discussion.

Thanks for giving this some thought!

Having looked at CoreDNS and some of the middleware implementations, how do you think dingo could be "ported over" to CoreDNS? In particular, I wouldn't be willing to convert dingo to a plugin, I want to remain it as a standalone project (eg. due to simplicity & compiled binary size).

Fair enough and I can understand that. My (not sure if it will work) idea is to
supplement the proxy middleware and add an option to speak dns-over-https to
some endpoint (healthchecking and the other stuff would then be relatively
free).
Another idea would be a complete stand alone middleware that can act as proxy.

So, maybe an option to go would be to make it possible to use dingo as a Go library?

That could work, but wouldn't that be relatively basic dns-json to dns
translator?

Besides, why just using the "proxy" CoreDNS middleware pointed at dingo running on loopback wouldn't be sufficient?

Yes, that could work, but would be more of a hassle to setup.

/Miek

Miek Gieben

@miekg
Copy link
Author

miekg commented Nov 25, 2016

Just looking at this code I see you made it GPL v3 - this mean I can not use it in CoreDNS (I think). Any reason you made it GPL and not BSD (or dual license)?

@pforemski
Copy link
Owner

BSD doesn't satisfy my needs. I want to protect my code from being used & modified for commercial products without releasing the source code back (at least I want protection in the legal sense). However, didn't think about the licensing too much, GPL just been my default for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants