diff --git a/src/core-taggeds-optional/Optional.Tests.Old/Absent.Tests/Base/AbsentTestsBase.Comparison.cs b/src/core-taggeds-optional/Optional.Tests.Old/Absent.Tests/Base/AbsentTestsBase.Comparison.cs index 96378b14..f95ea9be 100644 --- a/src/core-taggeds-optional/Optional.Tests.Old/Absent.Tests/Base/AbsentTestsBase.Comparison.cs +++ b/src/core-taggeds-optional/Optional.Tests.Old/Absent.Tests/Base/AbsentTestsBase.Comparison.cs @@ -17,46 +17,4 @@ public void Comparison_CompareTo_ValueAndDefault_ExpectZero() var actual = Absent.Value.CompareTo(default); Assert.That(actual, Is.Zero); } - - [Test] - public void Comparison_CompareToObj_NewAndNull_ExpectOne() - { - var actual = new Absent().CompareTo(null); - Assert.That(actual, Is.Positive); - Assert.That(actual, Is.EqualTo(1)); - } - - [Test] - public void Comparison_CompareToObj_ValueAndNull_ExpectOne() - { - var actual = Absent.Value.CompareTo(null); - Assert.That(actual, Is.Positive); - Assert.That(actual, Is.EqualTo(1)); - } - - [Test] - public void Comparison_CompareToObj_NewAndDefault_ExpectZero() - { - var actual = new Absent().CompareTo((object?)default(Absent)); - Assert.That(actual, Is.Zero); - } - - [Test] - public void Comparison_CompareToObj_ValueAndDefault_ExpectZero() - { - var actual = Absent.Value.CompareTo((object?)new Absent()); - Assert.That(actual, Is.Zero); - } - - [Test] - public void Comparison_CompareToObj_NewAndAnotherType_ExpectZero() - { - Assert.Throws(() => _ = new Absent().CompareTo(new object())); - } - - [Test] - public void Comparison_CompareToObj_ValueAndAnotherType_ExpectZero() - { - Assert.Throws(() => _ = Absent.Value.CompareTo(new object())); - } } diff --git a/src/core-taggeds-optional/Optional/Absent.T/Absent.T.Comparison.cs b/src/core-taggeds-optional/Optional/Absent.T/Absent.T.Comparison.cs index 4256c81f..c53022d3 100644 --- a/src/core-taggeds-optional/Optional/Absent.T/Absent.T.Comparison.cs +++ b/src/core-taggeds-optional/Optional/Absent.T/Absent.T.Comparison.cs @@ -3,13 +3,4 @@ partial struct Absent { public int CompareTo(Absent other) => default; - - public int CompareTo(object? obj) => obj switch - { - null => ComparisonResult.GreaterThan, - - Absent => ComparisonResult.EqualTo, - - _ => throw new ArgumentException($"The object is not Absent<{typeof(T).Name}>.", nameof(obj)) - }; } diff --git a/src/core-taggeds-optional/Optional/Absent.T/Absent.T.cs b/src/core-taggeds-optional/Optional/Absent.T/Absent.T.cs index e4dda33f..eb6a230b 100644 --- a/src/core-taggeds-optional/Optional/Absent.T/Absent.T.cs +++ b/src/core-taggeds-optional/Optional/Absent.T/Absent.T.cs @@ -1,5 +1,5 @@ namespace System; -public readonly partial struct Absent : IEquatable>, IComparable>, IComparable +public readonly partial struct Absent : IEquatable>, IComparable> { } diff --git a/src/core-taggeds-optional/Optional/OptionalExtensions/CompareTo/CompareTo.cs b/src/core-taggeds-optional/Optional/OptionalExtensions/CompareTo/CompareTo.cs index 8aca4c57..232af758 100644 --- a/src/core-taggeds-optional/Optional/OptionalExtensions/CompareTo/CompareTo.cs +++ b/src/core-taggeds-optional/Optional/OptionalExtensions/CompareTo/CompareTo.cs @@ -8,16 +8,4 @@ partial class OptionalExtensions internal static int CompareTo(this Optional optional, Optional other) where T : IComparable => optional.InternalCompareTo(other, Comparer.Default); - - // TODO: Add the tests and open the method - internal static int CompareTo(this Optional optional, object? obj) where T : IComparable - => - obj switch - { - null => ComparisonResult.GreaterThan, - - Optional other => optional.CompareTo(other), - - _ => throw new ArgumentException($"The object is not Optional<{typeof(T).Name}>.", nameof(obj)) - }; }