Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERD parent_child relation issue #8389

Closed
RajabSakalaki opened this issue Jan 22, 2025 · 2 comments
Closed

ERD parent_child relation issue #8389

RajabSakalaki opened this issue Jan 22, 2025 · 2 comments
Assignees
Milestone

Comments

@RajabSakalaki
Copy link

Please note that security bugs or issues should be reported to [email protected].

the ERD tool fail to open a file once there is a relation parent_child in the same table1(pk , name_, parent_id)
if the parent_id reference the same table table1(pk) it fail

A clear and concise description of what the bug is.

**To Reproduce**

create a table as above and foreign key

Error message

tmp.json

still loading.....

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows 10
  • Version: 22H2
  • Mode: Desktop
  • Package type: Python
@pms967
Copy link

pms967 commented Feb 7, 2025

+1, Confirmed.

I removed from the DB the only self-referring relationship (FK to PK of the same table) I had added on the project, re-generated the ERD, saved it to a .pgerd file, and now the new file can be loaded without problems (*).

Interestingly enough, if I remove the relationship ONLY on the ERD (but not on the actual DB) and save the modified .pgerd file, the problem is still there.

(*) The problem with saving images #8424 remains, though. That's likely unrelated.

pravesh-sharma added a commit to pravesh-sharma/pgadmin4 that referenced this issue Feb 17, 2025
…there was a parent-child relationship within the same table. pgadmin-org#8389
pravesh-sharma added a commit to pravesh-sharma/pgadmin4 that referenced this issue Feb 17, 2025
…there was a parent-child relationship within the same table. pgadmin-org#8389
adityatoshniwal added a commit that referenced this issue Feb 17, 2025
…ng parent-child relationship within the same table. #8389

Fixed an issue in ERD where link notation end-points were not rendering occasionally.

---------

Co-authored-by: Aditya Toshniwal <[email protected]>
@pravesh-sharma pravesh-sharma moved this from 🏗 In Progress to In Testing in Current Sprint (188) Feb 17, 2025
@pravesh-sharma pravesh-sharma removed their assignment Feb 17, 2025
@pravesh-sharma pravesh-sharma added this to the 9.1 milestone Feb 17, 2025
@RohitBhati8269
Copy link
Contributor

Tested and verified on snapshot build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2025-02-25/
Package: wheel
Environment: macOs Sequoia 15.0.1

@RohitBhati8269 RohitBhati8269 moved this from In Testing to ✅ Done in Current Sprint (188) Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants