Running tests

[a-masterov]

Dear Partman Team,

I installed pg_partman 5.2.4, on PostgreSQL 16.3 and tried running built-in tests, and some of them failed, e.g.

$ pg_prove -ofv test/test-dump-definition.sql

test/test-dump-definition.sql .. 
partman, public
1..4
ok 1 - When adding a new column to part_config please ensure it is also added to the dump_partitioned_table_definition function and the tests in this file
t
SELECT public.create_parent(
	p_parent_table := 'partman_test.declarative_objects',
	p_control := 'created_at',
	p_interval := '7 days',
	p_type := 'range',
	p_epoch := 'none',
	p_premake := 2,
	p_default_table := 't',
	p_automatic_maintenance := 'on',
	p_constraint_cols := NULL,
	p_template_table := NULL,
	p_jobmon := 't',
	p_date_trunc_interval := NULL,
	p_control_not_null := 't'
);
UPDATE public.part_config SET
	optimize_constraint = 30,
	retention = '5 weeks',
	retention_schema = NULL,
	retention_keep_index = 't',
	retention_keep_table = 'f',
	infinite_time_partitions = 't',
	datetime_string = 'YYYYMMDD',
	sub_partition_set_full = 'f',
	inherit_privileges = 't',
	constraint_valid = 'f',
	ignore_default_data = 't',
	maintenance_order = NULL,
	retention_keep_publication = 'f'
WHERE parent_table = 'partman_test.declarative_objects';
not ok 2
# Failed test 2
#         have: SELECT public.create_parent(
# 	p_parent_table := 'partman_test.declarative_objects',
# 	p_control := 'created_at',
# 	p_interval := '7 days',
# 	p_type := 'range',
# 	p_epoch := 'none',
# 	p_premake := 2,
# 	p_default_table := 't',
# 	p_automatic_maintenance := 'on',
# 	p_constraint_cols := NULL,
# 	p_template_table := 'public.template_partman_test_declarative_objects',
# 	p_jobmon := 't',
# 	p_date_trunc_interval := NULL,
# 	p_control_not_null := 't'
# );
# UPDATE public.part_config SET
# 	optimize_constraint = 30,
# 	retention = '5 weeks',
# 	retention_schema = NULL,
# 	retention_keep_index = 't',
# 	retention_keep_table = 'f',
# 	infinite_time_partitions = 't',
# 	datetime_string = 'YYYYMMDD',
# 	sub_partition_set_full = 'f',
# 	inherit_privileges = 't',
# 	constraint_valid = 'f',
# 	ignore_default_data = 't',
# 	maintenance_order = NULL,
# 	retention_keep_publication = 'f'
# WHERE parent_table = 'partman_test.declarative_objects';
#         want: SELECT partman.create_parent(
# 	p_parent_table := 'partman_test.declarative_objects',
# 	p_control := 'created_at',
# 	p_interval := '7 days',
# 	p_type := 'range',
# 	p_epoch := 'none',
# 	p_premake := 2,
# 	p_default_table := 't',
# 	p_automatic_maintenance := 'on',
# 	p_constraint_cols := NULL,
# 	p_template_table := 'partman.template_partman_test_declarative_objects',
# 	p_jobmon := 't',
# 	p_date_trunc_interval := NULL,
# 	p_control_not_null := 't'
# );
# UPDATE partman.part_config SET
# 	optimize_constraint = 30,
# 	retention = '5 weeks',
# 	retention_schema = NULL,
# 	retention_keep_index = 't',
# 	retention_keep_table = 'f',
# 	infinite_time_partitions = 't',
# 	datetime_string = 'YYYYMMDD',
# 	sub_partition_set_full = 'f',
# 	inherit_privileges = 't',
# 	constraint_valid = 'f',
# 	ignore_default_data = 't',
# 	maintenance_order = NULL,
# 	retention_keep_publication = 'f'
# WHERE parent_table = 'partman_test.declarative_objects';
psql:test/test-dump-definition.sql:112: NOTICE:  Moved 0 row(s) to the target table. Removed 8 partitions.
(8,0)
t
ok 3
(6,0)
psql:test/test-dump-definition.sql:135: NOTICE:  Moved 0 row(s) to the target table. Removed 6 partitions.
t
ok 4
# Looks like you failed 1 test of 4
Failed 1/4 subtests 

Test Summary Report
-------------------
test/test-dump-definition.sql (Wstat: 0 Tests: 4 Failed: 1)
  Failed test:  2
Files=1, Tests=4,  0 wallclock secs ( 0.01 usr +  0.01 sys =  0.02 CPU)
Result: FAIL

Is it expected?

[keithf4]

The pg_partman unit tests expect that pg_partman is installed in the partman schema. It looks like you have it installed in the public schema.

have

# 	p_template_table := 'public.template_partman_test_declarative_objects',

vs want

# 	p_template_table := 'partman.template_partman_test_declarative_objects',
~``