Performance Issue: Redundant has Call in get Method Slowing Down Redis

[kunalray1993]

cphalcon/phalcon/Storage/Adapter/AbstractAdapter.zep

Line 166 in 83677f1

if (true !== this->has(key)) {

Description

After upgrading Phalcon from 4.0.6 to 5.8.0 and PHP from 7.2 to 8.3, we noticed a performance issue related to the get method when using Redis as a cache backend. The method first calls has (which internally executes an EXISTS command) before calling get, effectively doubling the number of Redis operations. Under high traffic, this redundancy negatively impacts Redis performance.

Expected Behavior

The get method should retrieve the value directly without first checking for existence, unless absolutely necessary. The default value handling should be done in a more optimized manner.

Current Behavior

1. The get method first calls has -> Redis executes EXISTS key.
2. Then, get is called -> Redis executes GET key.
3. This results in two commands for every single retrieval operation, reducing efficiency under load.

Steps to Reproduce

1. Upgrade Phalcon from 4.0.6 to 5.8.0.
2. Use Redis as a cache backend.
3. Call $cache->get('some_key', 'default_value') in a high-traffic scenario.
4. Monitor Redis and observe the EXISTS call happening before GET.

Proposed Solution

Modify the get method to avoid calling has. Instead, rely on the GET result directly:

• If GET returns null (or false), use the default value.
• This would eliminate the extra EXISTS call and improve Redis performance.

Environment

• Phalcon Version: 5.8.0
• PHP Version: 8.3
• Redis Version: 7.0.15
• Operating System: Ubuntu 22.04

Would it be possible to optimize the get method to avoid this redundancy? Looking forward to your feedback.

[noone-silent]

I noticed that too. We should remove all additional checks for methods that using has. It is the users responsibility to check if the key exists and act accordingly in their code. This change does not only affect redis, it affects all providers.

[francoisgrogor]

Upvote this. This needs to be addressed please.