From 5f571fd2478cb6421bb07a3162cdeb90e636f00e Mon Sep 17 00:00:00 2001 From: Durieux Pol Date: Tue, 16 Apr 2024 16:51:57 +0200 Subject: [PATCH] changed default budget --- src/MuTalk-Model/MTAnalysis.class.st | 17 ++++------------- src/MuTalk-Tests/MTAnalysisTest.class.st | 11 ----------- 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/src/MuTalk-Model/MTAnalysis.class.st b/src/MuTalk-Model/MTAnalysis.class.st index 0378680..337bd6f 100644 --- a/src/MuTalk-Model/MTAnalysis.class.st +++ b/src/MuTalk-Model/MTAnalysis.class.st @@ -53,9 +53,8 @@ MTAnalysis >> coverageAnalysisResult: anObject [ { #category : 'accessing - defaults' } MTAnalysis >> defaultBudget [ - "Since tests often take little time to run, we multiply it by 30" - ^ MTTimeBudget for: self totalTestsTime * 30 + ^ MTTimeBudget for: 5 minutes ] { #category : 'accessing - defaults' } @@ -175,7 +174,8 @@ MTAnalysis >> initialize [ mutantResults := OrderedCollection new. elapsedTime := 0. logger := self defaultLogger. - stopOnErrorOrFail := true + stopOnErrorOrFail := true. + budget := self defaultBudget ] { #category : 'accessing' } @@ -277,8 +277,7 @@ MTAnalysis >> run [ ^ [ self initialTestRun. - "The budget is started after the initial test run because the default one needs the run time of tests" - self startBudget. + budget start. logger logAnalysisStartFor: self. elapsedTime := [ self generateCoverageAnalysis. @@ -292,14 +291,6 @@ MTAnalysis >> run [ false ] ] -{ #category : 'starting' } -MTAnalysis >> startBudget [ - "The budget is initialized here because the default one needs the run time of tests, so the initial test run must be executed first" - - budget ifNil: [ budget := self defaultBudget ]. - budget start -] - { #category : 'accessing' } MTAnalysis >> stopOnErrorOrFail: aBoolean [ diff --git a/src/MuTalk-Tests/MTAnalysisTest.class.st b/src/MuTalk-Tests/MTAnalysisTest.class.st index 486a923..8737de7 100644 --- a/src/MuTalk-Tests/MTAnalysisTest.class.st +++ b/src/MuTalk-Tests/MTAnalysisTest.class.st @@ -101,17 +101,6 @@ MTAnalysisTest >> testErrorWhenInitializingDefaultTestFilterBeforeInitialTestRun self should: [ analysis initializeTestFilter ] raise: Error ] -{ #category : 'tests' } -MTAnalysisTest >> testErrorWhenStartingDefaultBudgetBeforeInitialTestRun [ - - | analysis | - analysis := MTAnalysis new - classesToMutate: { MTAuxiliarClassForMTAnalysis }; - testClasses: { MTAuxiliarClassForMTAnalysisTest }. - - self should: [ analysis startBudget ] raise: Error -] - { #category : 'tests' } MTAnalysisTest >> testErrorWhenTryingToGetPercentileOfEmptyCollection [