Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a folder after creating and expanding it not possible #2031

Open
cz-dev-ge opened this issue Jan 7, 2025 · 4 comments
Open

Renaming a folder after creating and expanding it not possible #2031

cz-dev-ge opened this issue Jan 7, 2025 · 4 comments
Labels
bug Something isn't working High priority SLA 1 business day response time

Comments

@cz-dev-ge
Copy link

Describe the bug

When creating a folder and expanding it phoenix keeps a hold on it and prevents the user from renaming or otherwise modify it.

Reproduction

  1. Open a folder with sub folders with Phoenix Code
  2. Right click on a sub folder in the tree view
  3. duplicate
  4. unfold / expand the new folder in the tree view
  5. right click the outer folder
  6. rename
  7. error: cannot rename
  8. collapse folder in tree view and try again
  9. still cannot rename
  10. try from the windows explorer
  11. still not possible
  12. close Phoenix Code
  13. now renaming works fine

Expected behavior

I can rename the folder.

OS, Browser and Phoenix versions

  1. Win 11
  2. Release 3.10 build 3.10.0-20682

logs or debug stack trace if any

No response

Additional context

No response

@cz-dev-ge cz-dev-ge added the bug Something isn't working label Jan 7, 2025
@cz-dev-ge
Copy link
Author

cz-dev-ge commented Jan 7, 2025

This even happens when creating a folder in the same folder which is open in Phoenix Code from Windows Explorer. Even when omitting the expand step.

  1. Open folder in PhCode
  2. Open folder in Windows Explorer
  3. Create new sub folder with WE
  4. Try to rename it with WE
  5. not working until PhCode is closed

@abose
Copy link
Member

abose commented Jan 9, 2025

Thanks for the detailed steps @cz-dev-ge . I will take a look at it.

@abose
Copy link
Member

abose commented Jan 10, 2025

Windows only issue, related to file watchers. See more details in below link
paulmillr/chokidar#664

use polling will fix this, but need to analyze the performance impact

@abose abose added the High priority SLA 1 business day response time label Jan 10, 2025
@abose
Copy link
Member

abose commented Jan 10, 2025

This will be fixed in the next release. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High priority SLA 1 business day response time
Projects
None yet
Development

No branches or pull requests

2 participants