Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API addic7ed.com changed, tool no langer works #90

Open
mister131 opened this issue Mar 13, 2019 · 34 comments
Open

API addic7ed.com changed, tool no langer works #90

mister131 opened this issue Mar 13, 2019 · 34 comments

Comments

@mister131
Copy link

No description provided.

@Wally73
Copy link

Wally73 commented Mar 19, 2019

you mean api of thetvbd changed (addicted hasn't have an api (yet, they are working on it though)

the tvdb urls are changed to new format

subtools gives [ERROR] Error occured with httpclient response: 301 Moved Permanently

@Denniswolt
Copy link

Denniswolt commented Mar 22, 2019

Is it possible to fix this? Opensubtitles seems to be working.

@Wally73
Copy link

Wally73 commented Mar 25, 2019

by more investigation its due the fact that addicted has implemented recaptcha v2 for logins

@Denniswolt
Copy link

So that means this tool no longer works, or can this be fixed?

@TheFonZzz
Copy link

Same kind of error with Opensubtitles.
Hopefully someone can help the maker to solve these problems.

@Denniswolt
Copy link

Can somebody make it work again please? Or point to alternatives?

@EotT123
Copy link
Contributor

EotT123 commented Sep 5, 2022

Fixed in #93, although addic7ed is very slow.

@TheFonZzz
Copy link

Fixed in #93, although addic7ed is very slow.

Thank you very much for picking up this problem after a long, long time.
Unfortunatly it doesn't work here, I keep on getting an INI error... Maybe I've got to reinstall JAVA.

@TheFonZzz
Copy link

I did reinstalled JAVA with the latest version, but still I keep on getting an INI error. Anything I can do to fix this problem ??

@EotT123
Copy link
Contributor

EotT123 commented Sep 14, 2022

You need the latest java version (java 18). I use the latest OpenJdk, which you can download here: https://jdk.java.net/18/. But I don't think this is the problem.
Can you describe the error you are getting a bit more? Is there any more info?

@TheFonZzz
Copy link

I use Java build 1.8.0_341-b10.
The error I get in the pop-up screen is:
"Error, a INI Errror has occurred, please check your installation and try again"
"A Java exception has occurred".

The last version of Multisubdownloader (13.0 with dependecies) works still fine (offcourse with the known API errors like reported above).

@EotT123
Copy link
Contributor

EotT123 commented Sep 14, 2022

You are using java 8, not 18.

@TheFonZzz
Copy link

Java 8 is the latest (consumer) version. The JDK version is indeed at version 18, but I don't know whether it is a wise thing to install a Developer verion on a regular PC.

@EotT123
Copy link
Contributor

EotT123 commented Sep 15, 2022

You don't need the jdk indeed, because it includes many things you don't need. But it isn't 'bad' either.
In case you don't want to download the full jdk package, there are much smaller jre packages available here: https://adoptium.net/temurin/releases/?version=18

FYI: In a few days, java 19 will be released. I'm planning to update to this version, to be able to use new features. Those new feature aren't important for a normal user, but you can still benefit from the optimizations regaring performance and memory usage.

Edit: I'll probably won't update to 19, the new features I was going to use are still in preview mode.

@TheFonZzz
Copy link

I installed the JDK version, but I still keep on getting errors like:
[ERROR] createRelease
[ERROR] Unknown serie name in tvdb: The Rookie
Only one serie and one movie are showing up.

@Denniswolt
Copy link

Denniswolt commented Sep 20, 2022

I have the exact same error.
The error I get in the pop-up screen is:
"Error, a INI Errror has occurred, please check your installation and try again"
"A Java exception has occurred".

Fixed it bu installing: https://www.oracle.com/java/technologies/downloads/#jdk18-windows

@EotT123
Copy link
Contributor

EotT123 commented Sep 25, 2022

[ERROR] createRelease [ERROR] Unknown serie name in tvdb: The Rookie Only one serie and one movie are showing up.

This will probably be fixed in the new version. I've created a new PR: #108

@Denniswolt
Copy link

Denniswolt commented Sep 27, 2022 via email

@EotT123
Copy link
Contributor

EotT123 commented Sep 28, 2022

To solve this, you have to create an account on opensubtitle and add the credentials in the settings menu. Otherwise, you'll be limited to download 5 subtitles per 24 hours. (see #91). The old api is deprecated and will be removed (by opensubtitles, so there is nothing I can do about that).

@Denniswolt
Copy link

To solve this, you have to create an account on opensubtitle and add the credentials in the settings menu. Otherwise, you'll be limited to download 5 subtitles per 24 hours. (see #91). The old api is deprecated and will be removed (by opensubtitles, so there is nothing I can do about that).

I did that, but still the same errror

@EotT123
Copy link
Contributor

EotT123 commented Oct 2, 2022

Which version are you using? The latest released version (1.4.0)? Or did you build a version yourself based on the latest code? It's possible that there was a problem which is already fixed.
I've attached a new version which is based on the latest code in case you can't build it yourself: multisubdownloader-1.4.1-SNAPSHOT-jar-with-dependencies.jar.zip

@Denniswolt
Copy link

I was using 1.4.0. I don't know how to build a version myself. Thank you for 1.4.1. Seems to be working perfect. Except it disregards the excluded folders to scan.

@TheFonZzz
Copy link

I tried the 1.4.1 version and it looks very nice (great option with the automatic search for series). But I get dozens of this ERROR line:

[ERROR] API OpenSubtitles searchSubtitles for serie [Day of the Dead S01E04] (Cannot invoke "org.lodder.subtools.multisubdownloader.subtitleproviders.opensubtitles.api.v2.OpenSubtitlesApi.searchSubtitles()" because the return value of "org.lodder.subtools.multisubdownloader.subtitleproviders.adapters.JOpenSubAdapter.getApi()" is null)

@EotT123
Copy link
Contributor

EotT123 commented Oct 8, 2022

I'm working on a new version, but it takes some time.
@Denniswolt Excluded folders is indeed bugged, I'll try to fix it in the new version.
@TheFonZzz I also encountered that error, but it disappeared when I tried it a second time. I'll also have a look at this.

@TheFonZzz
Copy link

I'm working on a new version, but it takes some time. @Denniswolt Excluded folders is indeed bugged, I'll try to fix it in the new version. @TheFonZzz I also encountered that error, but it disappeared when I tried it a second time. I'll also have a look at this.

Great news, thank you for your work.
I know it can take a lot of time, for making a new version. We will wait with patient..

@EotT123
Copy link
Contributor

EotT123 commented Oct 22, 2022

A new version is ready, I've created a new PR: #115

@Denniswolt Exclude folders should be fixed.
@TheFonZzz I'm not 100% sure that the error is gone. Please try the new version and let me know if you still encounter that error.

If you don't want to wait until a new version is released, you could already try this one:
multisubdownloader-1.5.1-SNAPSHOT-jar-with-dependencies.zip

@TheFonZzz
Copy link

Thank you @EotT123 for this new version.
It starts good and it runs fine till it stuck at one serie. I couldn't find an option to add this one manual which might solve the problem..
Here's the part of the logging from where it gone wrong:
[ERROR] createRelease
[TRACE] Parsing match found using file name: Doc.Martin.S010E05.1080p.STV.WEB-DL.AAC2.0.H.264[eztv.re].avi
[TRACE] extractReleasegroup: name: Doc.Martin.S010E05.1080p.STV.WEB-DL.AAC2.0.H.264[eztv.re].avi , hasExtension: true
[TRACE] extractReleasegroup: release group:
[TRACE] getQualityKeyword: name: Doc.Martin.S010E05.1080p.STV.WEB-DL.AAC2.0.H.264[eztv.re].avi
[TRACE] getQualityKeyWords: keyswords: 1080p WEB-DL

@EotT123
Copy link
Contributor

EotT123 commented Oct 23, 2022

@TheFonZzz This is still original code of phdelodder, I haven't touched that part. I could try to improve it, but for now, you could rename your file to Doc.Martin.S10E05.1080p.STV.WEB-DL.AAC2.0.H.264[eztv.re].avi (S010E05 -> S10E05).

@Denniswolt
Copy link

[ERROR] API Addic7ed searchSubtitles for serie [New Amsterdam (2018) S05E04] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [New Amsterdam (2018) S05E05] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [New Amsterdam (2018) S05E06] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [S.W.A.T. (2017) S06E01] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [S.W.A.T. (2017) S06E02] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [S.W.A.T. (2017) S06E03] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))
[ERROR] API Addic7ed searchSubtitles for serie [SEAL Team S06E05] (Exception while getting value (org.lodder.subtools.sublibrary.ManagerException: Error occured with httpclient response: 302 Moved Temporarily))

Addic7ed does not seem to be working.

@EotT123
Copy link
Contributor

EotT123 commented Oct 29, 2022

You can try the Addic7ed proxy (can be selected in Serie providers tab in settings)

@TheFonZzz
Copy link

This is an error I see since working with the latest version (1.5.1)

[ERROR] API OpenSubtitles searchSubtitles for serie [Yellowstone (2018) S05E08] (org.lodder.subtools.multisubdownloader.subtitleproviders.opensubtitles.exception.OpenSubtitlesException: org.opensubtitles.invoker.ApiException: Message:
HTTP response code: 429
HTTP response body: {
"message":"API rate limit exceeded"

@EotT123
Copy link
Contributor

EotT123 commented Jan 2, 2023

@TheFonZzz OpenSubtitles is blocking your request, because you have done too many requests.
This case is handled by the code: it waits 5 seconds before trying again. But apparently, OpenSubtitles is still blocking the requests. I could not reproduce this behavior. Does this happen at the first subtitle you are searching with OpenSubtitles, or only after a while? Is it solved if you try again later?

Btw, 1.5.1 is not yet released, new 1.5.1 versions are build automatically when new features or fixes are added. You can find the latest nightly build here: https://github.com/phdelodder/SubTools/actions . The top row contains the latest build.
The new version will include automatic/manual checking for new stable and nightly versions (configurable in the settings).

@TheFonZzz
Copy link

@EotT123 It happens after a little while. Maybe because I've got so many titles for which I'm looking for subs (about 95).
It doesn't look like it waits 5 seconds before trying again. In that case it would take a much, much longer time before the program would be ready to search. But after about a minute it is already done.

I'll try that 1.5.0 version later today..

Thanks for all your work. I really appreciate.

@EotT123
Copy link
Contributor

EotT123 commented Jan 10, 2023

@TheFonZzz The 5 seond delay should only start when a request is blocked. So maybe 20 request can be done, followed by a wait of 5 seconds, before a new batch of 20 request can be done. So you'll only have to wait 30 seconds for the 95 requests. (These numbers are just to give you an example, I don't know how many requests can be done before a new request is blocked).
But it also possible that after a while and a bunch of requests, you have to wait longer than 5 sedonds. I implemented a retry mechanism, which will try again after 5 seconds, 3 times in a row. If the request is still blocked after all those retries, it will fail and is skipped (and you'll see an error message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants