Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search missing from mobile display size #106

Closed
jasalt opened this issue Dec 29, 2024 · 3 comments
Closed

Search missing from mobile display size #106

jasalt opened this issue Dec 29, 2024 · 3 comments

Comments

@jasalt
Copy link
Contributor

jasalt commented Dec 29, 2024

I often come to search for a specific function docs via the https://phel-lang.org/ front page. With mobile however I find myself stuck with the search bar being hidden on screen smaller than ~1040px.

Evidence

Testing with iPhone 13 Mini, Safari/Firefox:

Front page:
IMG_2353

Off-canvas / slide-out menu:
IMG_2352

Solution

Modify template style to show search bar on mobile:
Screenshot_20241229_112903

@jasalt
Copy link
Contributor Author

jasalt commented Dec 29, 2024

Commits fixing in PR #105:

@jasalt
Copy link
Contributor Author

jasalt commented Dec 29, 2024

There is still issue with smallest screens with search box overflowing.
I'll look if padding on left side or search-box min-width could be adjusted..
Screenshot_20241229_114315

@jasalt
Copy link
Contributor Author

jasalt commented Dec 29, 2024

One culprit leading to overflow seems to be #search text input background-image (the "s" button image) with it's related padding-left: 40px; shifting the placeholder content to start after it.

I'll add a (min-width: 400px) media query to show that "s" button icon only below that size so it should work..

layout-2024-12-29_12.17.36.mp4

jasalt added a commit to jasalt/phel-lang.org that referenced this issue Dec 29, 2024
@jasalt jasalt closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant