Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unloaded tab closed if (1) has childs and (2) is in root #118

Open
mkravchuk opened this issue Apr 15, 2011 · 0 comments
Open

Unloaded tab closed if (1) has childs and (2) is in root #118

mkravchuk opened this issue Apr 15, 2011 · 0 comments

Comments

@mkravchuk
Copy link

There are actually two issues:

  1. if the tab is in root tree and has children - then after unload all tree are closed!
  2. if tab has some parent - then after unload it moves to the end of owner node

I have found a resolution and tested the fix.
To fix this issue we should move the new tab (that replace actual tab) only after reassigning parent tabs to it, because whenever we assign a tab to owner tab - owner tab moves to the end of the tree.

Actual fix is:
in the file "modules\prototypes.js" move the line
---tabbrowser.moveTabTo(newtab, aTab._tPos + 1);
after the if condition
---// Restore tree when using Tree Style Tab
---if (tabbrowser.treeStyleTab) {

tested system: Windows 7 (x64)
Firefox version: 3.6
tested plug-in version: 2.1b2

Please publish this fix as as possible as this is a critical issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant