Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider recommending a max-width for grid examples #71

Open
shepmaster opened this issue Nov 9, 2015 · 1 comment
Open

Consider recommending a max-width for grid examples #71

shepmaster opened this issue Nov 9, 2015 · 1 comment

Comments

@shepmaster
Copy link

I took your grid example and added some SASS to get to a normal-ish 12 column layout. All was well and good until I put in a <pre> block with long lines. This blows out the cell and they no longer equally share the space.

An example.

The fix is simple — add a max-width that matches the percentage of the flex:

.Grid--1of2 > .Grid-cell {
  flex: 0 0 50%;
  max-width: 50%; // Add me
}

Also, I just noticed that a lot of those properties are missing a semicolon at the end, is that intentional?

Thanks for the great site! It makes using Flexbox super easy and makes me wish I didn't have to support IE9 at work!

@awps
Copy link

awps commented Apr 3, 2016

pre{
  white-space: pre-wrap;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants