Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Typescript definitions are outdated, API needs remirroring #1536

Open
fredgalvao opened this issue Jan 19, 2017 · 11 comments · Fixed by #1827
Open

Typescript definitions are outdated, API needs remirroring #1536

fredgalvao opened this issue Jan 19, 2017 · 11 comments · Fixed by #1827

Comments

@fredgalvao
Copy link
Collaborator

Expected Behaviour

100% API and settings/options coverage on typescript

Actual Behaviour

We're lacking clearAllNotifications there, at the very least. Needs reviewing.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

See #1530.

Plugin version

Latest on each main branch (1.9.x && 2.0.x)

@fredgalvao
Copy link
Collaborator Author

Update #1621 in type definition too.

@macdonst
Copy link
Member

macdonst commented Apr 3, 2017

@fredgalvao can we close this now?

@fredgalvao
Copy link
Collaborator Author

Nop. Having the definitions in-house made it easier, but not invalid. I'll still work on updating the interfaces/objects.

@kanak-infoObjects
Copy link

I am facing the same issue. Can't find the clearAllNotifications function. Please suggest a solution or an alternative. Thank you.

@fredgalvao
Copy link
Collaborator Author

@kanak-infoObjects I don't have an alternative. I'm sorry to say I haven't had the time to review the type definitions since forever, I'll try to get it done soon.
As always PRs and contributions are welcome.

@fredgalvao
Copy link
Collaborator Author

Even though clearAllNotifications is now typed, the full API still needs reviewing.

@stale
Copy link

stale bot commented Jun 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 3, 2018
@fredgalvao
Copy link
Collaborator Author

I'll close this and open a new one to actually update all the missing parts, as this is too old by now, and has been partially done over time.

@lock
Copy link

lock bot commented Jul 4, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2018
@fredgalvao
Copy link
Collaborator Author

It's time.

@fredgalvao fredgalvao reopened this Oct 23, 2018
@fredgalvao
Copy link
Collaborator Author

Some/most of the callbacks that have well defined parameters are not properly typed either.

Also, reminder to review #2607 and missing optionality on attributes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants