Failing Tests due to Gulp ESLint

[dvvanessastoiber]

• Release number or git hash: 7b200a4
• OS: Linux
• Environment (local or deployed): both

Steps to reproduce

1. Open generator repo
2. Run npm i to install the dependencies and generate the package-lock.json
3. Run npm run prepublishOnly

Observed behavior

• The tests failed, therefore we had to make the following modifications:
  • Add eslint dependencies to outer package.json (see https://github.com/phovea/generator-phovea/blob/master/package.json#L64-L82)
  • Switch to gulp-eslint-new, see package.json and gulpfile.js
  • Remove the testing step from the prepublish command, see https://github.com/phovea/generator-phovea/blob/master/gulpfile.js#L35

Might be related to adametry/gulp-eslint#250

Expected behavior

• The tests should run without failing