You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Internal\Path\Value\Path and Internal\Helper\PathHelper contain duplicative and inconsistent logic, suggesting a violation of the Single Responsibility Principle (SRP). This is apparent from the fact that each has an ::isAbsolute() method, but the one on Path hands protocols, whereas the one on PathHelper does not. All protocol-handling should be moved to Path. In fact, most path computation should be centralized in PathHelper, and Path should be trimmed to focus on the responsibilities of a true value object.
The text was updated successfully, but these errors were encountered:
Internal\Path\Value\Path
andInternal\Helper\PathHelper
contain duplicative and inconsistent logic, suggesting a violation of the Single Responsibility Principle (SRP). This is apparent from the fact that each has an::isAbsolute()
method, but the one onPath
hands protocols, whereas the one onPathHelper
does not. All protocol-handling should be moved toPath
. In fact, most path computation should be centralized inPathHelper
, andPath
should be trimmed to focus on the responsibilities of a true value object.The text was updated successfully, but these errors were encountered: