Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion of responsibilities between Internal\Path\Value\Path and Internal\Helper\PathHelper #327

Open
TravisCarden opened this issue Feb 20, 2024 · 0 comments

Comments

@TravisCarden
Copy link
Collaborator

Internal\Path\Value\Path and Internal\Helper\PathHelper contain duplicative and inconsistent logic, suggesting a violation of the Single Responsibility Principle (SRP). This is apparent from the fact that each has an ::isAbsolute() method, but the one on Path hands protocols, whereas the one on PathHelper does not. All protocol-handling should be moved to Path. In fact, most path computation should be centralized in PathHelper, and Path should be trimmed to focus on the responsibilities of a true value object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant