Solve C4267 warnings in win32/ioutil for x64 #17674
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C4267[1] are about conversion from `size_t` to a "smaller" type, causing potential loss of data (aka. truncation). In this case we can solve that cleanly (i.e. without casting and further checks) by changing the affected variables to be of type `DWORD`. [1] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267>
|
To clarify the PR/commit title: there is/was nothing to fix for x86, since both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C4267[1] are about conversion from
size_tto a "smaller" type, causing potential loss of data (aka. truncation).In this case we can solve that cleanly (i.e. without casting and further checks) by changing the affected variables to be of type
DWORD.[1] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267
Considering the full list of C4267 this is just a drop in the bucket, but as they are saying, constant dripping wears the stone. :)