Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize CLI app #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

dreglad
Copy link

@dreglad dreglad commented Apr 19, 2022

This PR containerizes this CLI tool

TODO:

  • Test the container image actualy works
  • Add a GitHub workflo to build and push a Docker image on releases
  • Update README

@dreglad dreglad changed the title Add basic Dockerfile Containerize CLI app Apr 19, 2022
@eclipxe13
Copy link
Member

Hi @dreglad.
Thanks for this PR.
Do you have the opportunity/willing to continue with this PR?

@dreglad dreglad marked this pull request as ready for review May 5, 2022 23:35
@dreglad
Copy link
Author

dreglad commented May 6, 2022

Hi @dreglad. Thanks for this PR. Do you have the opportunity/willing to continue with this PR?

@eclipxe13 Sure, I just pushed the remaning work and marked this PR as ready for review.

I included a GitHub workflow for continuously building and pushing the resulting Docker image into a public Docker registry. For simplicty, it assumes using the integrated gcr.io GitHub registry, but you might decide to publish into a different registry (e.g. Docker Hub) as well as you might want to set metadata image tags following your own conventions in case they differ from the semver pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants