Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependencies #6

Closed
rromanchuk opened this issue Nov 17, 2014 · 6 comments
Closed

Reduce dependencies #6

rromanchuk opened this issue Nov 17, 2014 · 6 comments
Assignees

Comments

@rromanchuk
Copy link
Contributor

This library needs to move away from RM DSL libraries, bubblewrap and afmotion specifically, using AFNetworking alone will just add a few more lines of code.

Including this in my gemfile adds 10MB of bloat, this is very very bad.

@rromanchuk
Copy link
Contributor Author

@colinta
Copy link

colinta commented Nov 17, 2014

I'll second this. BubbleWrap is useful for app development, but I don't think it's appropriate as a gem dependency. It is an opinionated library, and extends core classes.

@docstun
Copy link
Member

docstun commented Nov 19, 2014

We'll have a look. Any chance you want to contribute?

@docstun docstun self-assigned this Nov 19, 2014
@rromanchuk
Copy link
Contributor Author

Yeah, I'll send a PR later this week

Sent from my iPhone

On Nov 19, 2014, at 12:50 AM, Manuel Boy [email protected] wrote:

We'll have a look. Any chance you want to contribute?


Reply to this email directly or view it on GitHub.

@docstun
Copy link
Member

docstun commented Nov 19, 2014

Awesome! Highly appreciated!

@rromanchuk
Copy link
Contributor Author

@docstun done

@docstun docstun closed this as completed Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants