Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getErrors() missing 2 required positional arguments: 'timesES' and 'timesGT' #42

Closed
wgb-10 opened this issue Apr 15, 2022 · 1 comment · May be fixed by #43
Closed

getErrors() missing 2 required positional arguments: 'timesES' and 'timesGT' #42

wgb-10 opened this issue Apr 15, 2022 · 1 comment · May be fixed by #43

Comments

@wgb-10
Copy link

wgb-10 commented Apr 15, 2022

On running the start() method of the MultiMethodSuite class I noticed that the getErrors() function does not take the bvps and fps variables:

pyVHR/pyVHR/analysis/multi_method_suite.py

Line 279 in 2b1767d

RMSE, MAE, MAX, PCC, CCC = getErrors(median_bpmES, bpmGT, timesES, timesGT)

Like was done in run_on_dataset() in the Pipeline class here:

pyVHR/pyVHR/analysis/pipeline.py

Lines 411 to 412 in 2b1767d

RMSE, MAE, MAX, PCC, CCC, SNR = getErrors(bvps, fps,
np.expand_dims(median_bpmES, axis=0), bpmGT, timesES, timesGT)

This is why the above error occurs.
@wgb-10 wgb-10 mentioned this issue Apr 15, 2022
Open
@giulianogrossi
Copy link
Collaborator

A new version of the framework, pyVHR 2.0, has been released. Please check if problems persist and report them for future bug fixes.

best
the pyVHR team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix multi_method_suite.py wgb-10/pyVHR
2 participants
@giulianogrossi @wgb-10