Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmapped user mentions. #156

Open
karliss opened this issue Sep 22, 2022 · 1 comment
Open

Unmapped user mentions. #156

karliss opened this issue Sep 22, 2022 · 1 comment

Comments

@karliss
Copy link

karliss commented Sep 22, 2022

When migrating comments done by users without mapping the tool will leave @gitlabusername string in the comment text. But such username might already exist on github. Resulting in sending a notification to completely unrelated github user.

It would be somewhat safer if all @something strings which don't have a corresponding entry in user mapping were replaced by _at_something. Downside is that slightly ruin comments mentioning an email address or having a code block with @ symbol. But I think that would be less bad than annoying a bunch of users who have nothing to do with your repository. And in most cases for human reader could still understand the intended meaning.

@ViliusS
Copy link
Contributor

ViliusS commented Nov 16, 2022

I support this idea. For the moment you can achieve something similar by gathering all your GitLab usernames and mapping all of them to @ghost GitHub account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants