Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like #46

Open
ghost opened this issue Jul 2, 2016 · 1 comment
Open

Like #46

ghost opened this issue Jul 2, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 2, 2016

Since a like button usually lie in a detail page. Assume I have a blog post which URL is /post/4. When a anonymous user click the like boutton, he will redirect to the login page, with the url like
/accounts/login/next=?like/5/6. Once he login, a http get request send to that url, while we didn't implement the get method in our view, so a exception will be thrown.Do you think so?By the way, I didn't test it in real situation. I just analysis from the source code.

@grahamu
Copy link
Contributor

grahamu commented Jul 2, 2016

@zmrenwu thanks for your analysis. Writing a test to demonstrate behavior is the best way to get something changed. You might write a simple test showing this issue and submit a pull request for review. Thanks!

@jtauber jtauber added this to the post-16.07 milestone Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants