Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

The comments are in Chinese, there is a problem with log parsing #1472

Open
together-wang opened this issue Mar 2, 2021 · 2 comments
Open
Labels
type/feature-request This issue is a feature request

Comments

@together-wang
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    The comments are in Chinese, and the following content can be seen from the log of dm-master
    image
    image

  2. What did you expect to see?
    The configuration file does not display comment information in the log

  3. What did you see instead?
    Chinese comments in dm-master log are not parsed
    [INFO] [server.go:1990] [payload="task:\"---\\nname: t1\\ntask-mode: all # all \\345\\215\\263\\345\\205\\210\\350\\277\\233\\350\\241\\214\\345\\205\\250\\351\\207\\217\\345\\220\\214\\346\\255\\245\\357\\274\\214\\345\\205\\250\\351\\207\\217\\345\\220\\214\\346\\255\\245\\345\\256\\214\\346\\210\\220\\345\\220\\216\\350\\207\\252\\345\\212\\250\\350\\277\\233\\350\\241\\214\\345\\242\\236\\351\\207\\217\\346\\225\\260\\346\\215\\256\\345\\220\\214\\346\\255\\245\\ncase-sensitive: true\\ntarget-database:\\n host: \\\"172.16.5.215\\\"\\n port: 4200\\n user: \\\"root\\\"\\n password: \\\"\\\"\\n\\nmysql-instances: \\n -\\n source-id: \\\"mysql-replica-01\\\"\\n block-allow-list: \\\"instance\\\"\\n mydumper-thread: 4\\n loader-thread: 16\\n syncer-thread: 16\\n\\n\\nblock-allow-list:\\n instance:\\n do-dbs: [\\\"lianxi\\\"]\\n\\n\" "] [request=CheckTask]

  4. Versions of the cluster
    [tidb@node127 dm]$ tiup dm display dm1

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      Cluster version:    v2.0.1
      
    • Upstream MySQL/MariaDB server version:

      5.7.24
      
    • Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      Release Version: v5.0.0-rc
      
    • How did you deploy DM: DM-Ansible or manually?

      TIUP
      
    • Other interesting information (system version, hardware config, etc):

  5. current status of DM cluster (execute query-status in dmctl)

  6. Operation logs

    • Please upload dm-worker.log for every DM-worker instance if possible
    • Please upload dm-master.log if possible
    • Other interesting logs
    • Output of dmctl's commands with problems
  7. Configuration of the cluster and the task

    • dm-worker.toml for every DM-worker instance if possible
    • dm-master.toml for DM-master if possible
    • task config, like task.yaml if possible
    • inventory.ini if deployed by DM-Ansible
  8. Screenshot/exported-PDF of Grafana dashboard or metrics' graph in Prometheus for DM if possible

@lance6716
Copy link
Collaborator

DM now prints the original content of file to log. If we modify the content before printing, there's a little chance that the modification will hide an error and make it harder to locate problems. So I prefer not to "does not display comment information".

Please close the issue if agreed

@lance6716 lance6716 added type/feature-request This issue is a feature request and removed severity/minor type/bug This issue is a bug report labels Apr 7, 2021
@sunzhaoyang
Copy link

“prints the original content of file to log” is ok, but the problem is that the comments in the configuration file should not be in Chinese

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request This issue is a feature request
Projects
None yet
Development

No branches or pull requests

4 participants