From d088c8884b112e8066818719a3cdaad63769847b Mon Sep 17 00:00:00 2001 From: Ping Yu Date: Mon, 27 Jan 2025 08:38:30 +0800 Subject: [PATCH 1/2] Add ENGINE_ATTRIBUTE table option Signed-off-by: Ping Yu --- sql-statements/sql-statement-create-table.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sql-statements/sql-statement-create-table.md b/sql-statements/sql-statement-create-table.md index 453c6fbbbbeeb..4b62133d0eff6 100644 --- a/sql-statements/sql-statement-create-table.md +++ b/sql-statements/sql-statement-create-table.md @@ -109,7 +109,7 @@ TableOption ::= PartDefOption | DefaultKwdOpt ( CharsetKw EqOpt CharsetName | 'COLLATE' EqOpt CollationName ) | ( 'AUTO_INCREMENT' | 'AUTO_ID_CACHE' | 'AUTO_RANDOM_BASE' | 'AVG_ROW_LENGTH' | 'CHECKSUM' | 'TABLE_CHECKSUM' | 'KEY_BLOCK_SIZE' | 'DELAY_KEY_WRITE' | 'SHARD_ROW_ID_BITS' | 'PRE_SPLIT_REGIONS' ) EqOpt LengthNum -| ( 'CONNECTION' | 'PASSWORD' | 'COMPRESSION' ) EqOpt stringLit +| ( 'CONNECTION' | 'ENGINE_ATTRIBUTE' | 'PASSWORD' | 'COMPRESSION' ) EqOpt stringLit | RowFormat | ( 'STATS_PERSISTENT' | 'PACK_KEYS' ) EqOpt StatsPersistentVal | ( 'STATS_AUTO_RECALC' | 'STATS_SAMPLE_PAGES' ) EqOpt ( LengthNum | 'DEFAULT' ) @@ -128,7 +128,7 @@ PlacementPolicyOption ::= | "PLACEMENT" "POLICY" (EqOpt | "SET") "DEFAULT" ``` -The following *table_options* are supported. Other options such as `AVG_ROW_LENGTH`, `CHECKSUM`, `COMPRESSION`, `CONNECTION`, `DELAY_KEY_WRITE`, `ENGINE`, `KEY_BLOCK_SIZE`, `MAX_ROWS`, `MIN_ROWS`, `ROW_FORMAT` and `STATS_PERSISTENT` are parsed but ignored. +The following *table_options* are supported. Other options such as `AVG_ROW_LENGTH`, `CHECKSUM`, `COMPRESSION`, `CONNECTION`, `DELAY_KEY_WRITE`, `ENGINE`, `KEY_BLOCK_SIZE`, `MAX_ROWS`, `MIN_ROWS`, `ROW_FORMAT` and `STATS_PERSISTENT` are parsed but ignored. `ENGINE_ATTRIBUTE` are parsed but always return the `ERROR 3981 (HY000): Storage engine does not support ENGINE_ATTRIBUTE` error. This option is reserved for future use. | Options | Description | Example | | ---------- | ---------- | ------- | From 27b66ed0fb6a791a0db4d828d0830bd010105424 Mon Sep 17 00:00:00 2001 From: Ping Yu Date: Fri, 7 Feb 2025 11:32:53 +0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Ping Yu Co-authored-by: xixirangrang --- sql-statements/sql-statement-create-table.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-create-table.md b/sql-statements/sql-statement-create-table.md index 4b62133d0eff6..ec5142a20147e 100644 --- a/sql-statements/sql-statement-create-table.md +++ b/sql-statements/sql-statement-create-table.md @@ -128,7 +128,7 @@ PlacementPolicyOption ::= | "PLACEMENT" "POLICY" (EqOpt | "SET") "DEFAULT" ``` -The following *table_options* are supported. Other options such as `AVG_ROW_LENGTH`, `CHECKSUM`, `COMPRESSION`, `CONNECTION`, `DELAY_KEY_WRITE`, `ENGINE`, `KEY_BLOCK_SIZE`, `MAX_ROWS`, `MIN_ROWS`, `ROW_FORMAT` and `STATS_PERSISTENT` are parsed but ignored. `ENGINE_ATTRIBUTE` are parsed but always return the `ERROR 3981 (HY000): Storage engine does not support ENGINE_ATTRIBUTE` error. This option is reserved for future use. +The following *table_options* are supported. Other options such as `AVG_ROW_LENGTH`, `CHECKSUM`, `COMPRESSION`, `CONNECTION`, `DELAY_KEY_WRITE`, `ENGINE`, `KEY_BLOCK_SIZE`, `MAX_ROWS`, `MIN_ROWS`, `ROW_FORMAT` and `STATS_PERSISTENT` are parsed but ignored. `ENGINE_ATTRIBUTE` is parsed but always returns the `ERROR 3981 (HY000): Storage engine does not support ENGINE_ATTRIBUTE` error. This option is reserved for future use. | Options | Description | Example | | ---------- | ---------- | ------- |