Refresh the Spotify token when needed #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaopms is attempting to deploy a commit to the Raphael Marco's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Even though this PR hasn't been merged, the repo with all the fixes is public (including #38) and deployed at https://joaopms.github.io/spotify-now-playing-overlay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: The overlay continues working after 60 minutes.
This project was with using Spotify's Implicit Grant flow, which only worked for 60 minutes. After that, the access token used to fetch the currently playing song expires and the overlay stops updating.
By migrating to the Authorization Code with PKCE flow, we're now able to refresh the access token for as long as we need, meaning the overlay continues updating even after 60 minutes.
Fixes #21 and fixes #28 and fixes #39
Dependencies had to be updated to run on the latest Node.js LTS (version 20), which should close all of @app/dependabot PRs