From addce639d163f2a81553108ace862beea55137a0 Mon Sep 17 00:00:00 2001 From: Jeff Xiang Date: Thu, 26 Sep 2024 16:36:49 -0400 Subject: [PATCH] WIP all sink tests pass --- .../pinterest/flink/connector/psc/sink/PscCommitterTest.java | 5 ++++- .../connector/psc/sink/PscWriterStateSerializerTest.java | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java b/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java index 1f6f134..e30d3c7 100644 --- a/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java +++ b/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java @@ -107,7 +107,9 @@ public void commitTransaction() {} public void flush() {} @Override - public void close() {} + public void close() throws IOException { + super.close(); + } }; try (final PscCommitter committer = new PscCommitter(properties); Recyclable> recyclable = @@ -118,6 +120,7 @@ public void close() {} committer.commit(Collections.singletonList(request)); assertThat(recyclable.isRecycled()).isTrue(); + producer.close(); } } diff --git a/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java b/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java index 0903df1..cfde467 100644 --- a/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java +++ b/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java @@ -25,8 +25,8 @@ import static org.junit.Assert.assertEquals; /** - * Tests for serializing and deserialzing {@link KafkaWriterState} with {@link - * KafkaWriterStateSerializer}. + * Tests for serializing and deserialzing {@link PscWriterState} with {@link + * PscWriterStateSerializer}. */ public class PscWriterStateSerializerTest extends TestLogger {