Fix data race in WriteTo #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no harm in shadowing `err` in the goroutine since we do not need it outside of the routine. I also discovered data races in tcp_conn_test.go while fixing this bug and have included them in this PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 66.37% 66.14% -0.23%
==========================================
Files 43 43
Lines 3084 3084
==========================================
- Hits 2047 2040 -7
- Misses 871 877 +6
- Partials 166 167 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I am going to re-open these PRs. CI was broken, and will be working on new PR. sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no harm in shadowing
errin the goroutine since we do not need it outside of the routine.I also discovered data races in tcp_conn_test.go while fixing this bug and have included them in this PR.
Reference issue
Fixes #438