Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit broke /admin/ endpoint #235

Open
viktorsmari opened this issue Sep 4, 2019 · 0 comments
Open

Commit broke /admin/ endpoint #235

viktorsmari opened this issue Sep 4, 2019 · 0 comments

Comments

@viktorsmari
Copy link
Member

viktorsmari commented Sep 4, 2019

Git bisect tells me that this commit 388fecf broke the /admin:

Commit message:
CustomTermsAndConditionsRedirectMiddleware replaced with one from django-termsandconditions package, since they have now implemented the changes we needed.

Error:

UnicodeDecodeError at /admin/
'ascii' codec can't decode byte 0xc3 in position 13: ordinal not in range(128)

I think we need to add simple tests, that simply check multiple endpoints like /login /admin /issues etc, just to ensure they are working and not erroring.

That way, we won't notice 'by accident' if something random broke.

@viktorsmari viktorsmari changed the title Commit broke /admin/ Commit broke /admin/ endpoint Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant