Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Tab/Tree Context menu hotkey for TST #3450

Open
SHHSSH opened this issue Feb 6, 2024 · 6 comments
Open

[Feature request] Tab/Tree Context menu hotkey for TST #3450

SHHSSH opened this issue Feb 6, 2024 · 6 comments

Comments

@SHHSSH
Copy link

SHHSSH commented Feb 6, 2024

Hi Piroor,

As one would elsewhere in an operating system for files etc. with "Appplication" keys on some keyboards, is there at all the possibility for a hotkey in the options for the user to open the context menu for the current, or, selected tab?
https://ibb.co/yhvtv2n
It significantly increases efficiency for the user, whereby saving them the physical movement of the mouse cursor to the sidebar and would allow users to then henceforth press the corresponding access key.

EDIT This is probably out of scope as you'd say due to most helper addons and TST itself offering a myriad of hotkey customisation in their options. If so, I apologise and close this issue, I just thought it could be very useful universally in FF, but if you're not interested in it all, no worries :)

Thanks in advance, as always for any consideration at all.

@piroor
Copy link
Owner

piroor commented Feb 7, 2024

Which is an application your screenshot is taken about? My keyboard also has the application key (I think you meant the key with an menu-like icon), but Firefox looks to handle pressed app key as pressed on the main content area. After I click a sidebar contents the event for pressed app key is notified to the sidebar contents, so the behavior you described looks to be possible to implement, but you still need to click once on the sidebar, thus it looks inconvenient...

Anyway I've introduced a change to treat pressing of the application key as "context menu on the active tab" with the commit 6a903e4.

@piroor piroor added partially fixed Firefox-issue bug of Firefox itself and removed needs-triage labels Feb 7, 2024
@SHHSSH
Copy link
Author

SHHSSH commented Feb 7, 2024

Oh, yes, it's referred to as the Menu key. It has the functionality of Shift+F10 in windows for context menu I think?
I don't really know if it's really relevant to this though, I just used it as a reference for its context menu opening capabilities.

@SHHSSH
Copy link
Author

SHHSSH commented Feb 7, 2024

Oh, with the likelihood of having to click on the sidebar once for focus of sorts, perhaps I will work around that with another macro for its focus in conjunction with the opening of the menu(if possible).

Thanks for your consideration, I hope to have intrigued you somewhat.

@SHHSSH SHHSSH closed this as completed Jun 14, 2024
@SHHSSH SHHSSH reopened this Jun 24, 2024
@SHHSSH
Copy link
Author

SHHSSH commented Jun 24, 2024

@piroor
Is there any possible way to have this work without having TST sidebar "clicked/focused" as it's just not pratical to click onto TST sidebar then use the application key (menu-like icon key), at that point you masewell just right click the tab.

  • I am inquring to see if there is any potential option for sending this key's function to TST perhaps via an optional hotkey?
  • I understand the functionality is working if TST sidebar is focused, however, this is not any form of increased productivity.
  • I also understand that it is not feasible to allow for a universal command of "application key/menu-like icon key) to be able to be used as that would conflict with general universal webpage usage of the key.

I believe this would be immensely utilised by the community by providing an even more seamless productive flow allowing them to essentially "right click" on the current tab.

Thank in advance for any consideration as per usual.

No need to read;

Stupid needless information about my current workaround

At the moment I was trying to do workarounds with Alt-Tabbing to Show TST in New Window via multiple macros that were being scripted, then sending the application key, however, this is not a viable solution as when using multiple windows, they conflict with one another when trying to easily access multiple TSTs in New Window. My workaround is just not viable when using multiple windows, besides the fact it's just stupid anyway, having to press like 3+ keys for something that should be easier.

@piroor
Copy link
Owner

piroor commented Jun 25, 2024

Sadly it is impossible for now.

  • Firefox does not allow WebExtensions API based addons to provide ability to open native context menu by script.
  • Instead we can open the "fake" context menu simulated by TST itself (you'll see it by Ctrl-right-click on a tab in the sidebar.)
  • However you still cannot use cursor keys to move focus in the menu, while the sidebar contents is not focused. We need to define new keyboard shortcut slots and assign custom keyboard shortcuts like "Move Up Focus in the Fake Context Menu" to "Alt-Shift-Up" or others.

Thus, I think it won't be enough useful. Something utility application for gamers providing ability to send arbitrary message to applications may be better solution for this situation.

@SHHSSH
Copy link
Author

SHHSSH commented Jun 25, 2024

* Instead we can open the "fake" context menu simulated by TST itself (you'll see it by Ctrl-right-click on a tab in the sidebar.)

Yep, I am aware of this actually with the Ctrl-right-click, can this be invoked by a hotkey at all though?
Perhaps that's the solution? Although it does not provide the user with third-party addon context menu options, TST's context menu options are likely sufficient for many and me too. As with native Firefox context menu I don't even use many additional third party context menu options (only one "disable tab detach" but it's not that often used.
capture_002_26062024_055010

So would a hotkey implementation option be a reasonable approach here if that's at all possible to invoke TST's context menu?

If not, all good mate, cheers for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants