Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unloaded pinned tabs style #3624

Open
tinsoldat opened this issue Sep 7, 2024 · 5 comments
Open

[Bug] Unloaded pinned tabs style #3624

tinsoldat opened this issue Sep 7, 2024 · 5 comments
Labels
bug Firefox-issue bug of Firefox itself

Comments

@tinsoldat
Copy link

tinsoldat commented Sep 7, 2024

Abstract

Pinned tabs do not have a discarded class when a session is restored and browser.sessionstore.restore_pinned_tabs_on_demand is set to true in about:config.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Go to about:config
  4. Search for browser.sessionstore.restore_pinned_tabs_on_demand.
  5. Set it to true.
  6. Pin a tab.
  7. Switch to a different tab.
  8. Make sure that "Open previous windows and tabs" option is on.
  9. Close and then reopen Firefox.

Expected result

The pinned tabs should have a discarded class on them as they were not loaded yet.

Actual result

The discarded pinned tabs do not have .discarded as if they are loaded.

Environment

  • Platform (OS):
  • Version of Firefox: 130.0
  • Version (or revision) of Tree Style Tab: 4.0.22
@irvinm
Copy link
Contributor

irvinm commented Sep 8, 2024

@tinsoldat what CSS are you using? By default, it looks like the example TST CSS is all commented out and none is related to the discarded property.

@irvinm
Copy link
Contributor

irvinm commented Sep 8, 2024

@piroor I did take a look at the classes assigned to a "pinned & discarded" tab and the "discarded" class is not assigned to that type of tab. There doesn't seem to be a way to style discarded pinned tabs directly.

Pinned / Discarded

image

Pinned / Active

image

Non-pinned / Discarded

image

@irvinm
Copy link
Contributor

irvinm commented Sep 8, 2024

Related to: #1955 and #1530

@tinsoldat
Copy link
Author

@tinsoldat what CSS are you using? By default, it looks like the example TST CSS is all commented out and none is related to the discarded property.

Oh, it was from Tab Unloader for Tree Style Tab.

.tab.discarded {
  opacity: 0.75;
}

I'll edit so that the issue only refers to the class.

@piroor
Copy link
Owner

piroor commented Sep 10, 2024

It is a bug of Firefox itself as I commented at #1955 (comment) and I've found the bug about this tracked at bugzilla.mozilla.org.
1703072 - Restored pinned tabs discarded status always false

@piroor piroor added Firefox-issue bug of Firefox itself and removed needs-triage labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Firefox-issue bug of Firefox itself
Projects
None yet
Development

No branches or pull requests

3 participants