Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider case insensitive search of controlled vocabs #10948

Closed
touhidurabir opened this issue Feb 19, 2025 · 0 comments
Closed

Consider case insensitive search of controlled vocabs #10948

touhidurabir opened this issue Feb 19, 2025 · 0 comments
Assignees
@touhidurabir
Milestone
3.5 Internal

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Feb 19, 2025 •
edited
Loading

Describe the bug
When searching partially match controlled vocabs via API for PostgreSQL, need to consider the case insensitive match using ILIKE instead of LIKE . This is a regression introduced by #10292 . This cause the tests to fail for postgres.

What application are you using?
OJS, OMP or OPS version main (upcoming 3.5)

Additional information
example failures

PRs
pkp-lib --> #10949
ojs --> pkp/ojs#4673
@touhidurabir touhidurabir self-assigned this Feb 19, 2025
@touhidurabir touhidurabir added the Bug:2:Major A bug found in common paths that reduces functionality for a large number of users label Feb 19, 2025
@touhidurabir touhidurabir added this to the 3.5 Internal milestone Feb 19, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Feb 19, 2025
@touhidurabir
pkp#10948 Fixed case insensitive matching of vocabs
fe56411
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 19, 2025
@touhidurabir
pkp/pkp-lib#10948 Submodule Update ##touhidurabir/i10948_main##
c19741f
This was referenced Feb 19, 2025
Merged
Merged
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Feb 19, 2025
@touhidurabir
pkp#10948 Optimize delete query and resequence at vocab insertion
346ea85
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 19, 2025
@touhidurabir
pkp/pkp-lib#10948 Submodule Update ##touhidurabir/i10948_main##
9507cb6
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 19, 2025
@touhidurabir
pkp/pkp-lib#10948 added force click on metadata field before typing
f77dfbd
touhidurabir added a commit that referenced this issue Feb 19, 2025
@touhidurabir
Merge pull request #10949 from touhidurabir/i10948_main
848c70e 
#10948 Fixed case insensitive matching of vocabs
touhidurabir added a commit to pkp/ojs that referenced this issue Feb 19, 2025
@touhidurabir
Merge pull request #4673 from touhidurabir/i10948_main
06ae580 
pkp/pkp-lib#10948 Submodule Update ##touhidurabir/i10948_main##
@Tribunal33 Tribunal33 removed the Bug:2:Major A bug found in common paths that reduces functionality for a large number of users label Feb 19, 2025
Hafsa-Naeem pushed a commit to Hafsa-Naeem/ojs that referenced this issue Feb 20, 2025
@touhidurabir @Hafsa-Naeem
Merge pull request pkp#4673 from touhidurabir/i10948_main
2e788dd 
pkp/pkp-lib#10948 Submodule Update ##touhidurabir/i10948_main##
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
None yet
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@touhidurabir @Tribunal33