Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coro() method to return create and wrap values. #18

Open
johnd0e opened this issue Jun 3, 2015 · 0 comments
Open

Update coro() method to return create and wrap values. #18

johnd0e opened this issue Jun 3, 2015 · 0 comments

Comments

@johnd0e
Copy link

johnd0e commented Jun 3, 2015

This is commit from far-support branch: 0801f18

Discussed here: http://forum.farmanager.com/viewtopic.php?p=116873#p116873

Edit
The idea behind current coro is great: to hide all tricky doings into 1 high level function.
Unfortunately, it's not bullet proof enough, and to handle possible issues one must clearly understand what exactly is happening inside (and due to lack of documentation it's necessary to inspect mobdebug source code).

Thus the idea of 'highlevelness' of this function gets completely destroyed.
So I propose to make things a level lower, but a lot clearer way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant