Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is @types/geojson a required dependency? #132

Open
aqeelat opened this issue Jan 20, 2025 · 2 comments
Open

Why is @types/geojson a required dependency? #132

aqeelat opened this issue Jan 20, 2025 · 2 comments

Comments

@aqeelat
Copy link

aqeelat commented Jan 20, 2025

I don't think I've ever seen a type library declared as a dependency and I'm just curios as to why that is.
@tmcw
Copy link
Collaborator

tmcw commented Jan 20, 2025

Yeah, I think it should be a peerDependency, does that seem right? Previously, xmldom's type signature wasn't an issue but they started shipping a type that's incompatible with the Document type you get by default with TypeScript's lib option.

@tmcw
Copy link
Collaborator

tmcw commented Jan 27, 2025

Actually - @types/geojson is a peerDependency, and probably should be, though I need to confirm the particular behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @aqeelat