Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Transaction-Actions #3748

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

limebell
Copy link
Member

Alike block actions, transaction actions are being executed at before transaction, and after transaction.

Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about setting the merge target as main and deployment it in advance?

@riemannulus
Copy link
Member

How about setting the merge target as main and deployment it in advance?

NVM, it is ok

Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
@@ -134,7 +125,7 @@ public class ActionEvaluator : IActionEvaluator
}

var evaluations = ImmutableList<ActionEvaluation>.Empty;
if (_policyBeginBlockActionsGetter(block) is { } beginBlockActions &&
if (_policyActionsGetterCollection.BeginBlockActionsGetter(block) is { } beginBlockActions &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems too long... 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about shortening the name?
For example
BeginBlockActionsGetter -> BeginActions
_policyActionsGetterCollection -> _policyActions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify meanings of each variable, I decided to insert newline instead of shortening variable names.

Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
@limebell limebell merged commit 5cbb2c6 into planetarium:exp/dpos Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants