-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Transaction-Actions #3748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about setting the merge target as main and deployment it in advance?
NVM, it is ok |
Libplanet.Action/ActionEvaluator.cs
Outdated
@@ -134,7 +125,7 @@ public class ActionEvaluator : IActionEvaluator | |||
} | |||
|
|||
var evaluations = ImmutableList<ActionEvaluation>.Empty; | |||
if (_policyBeginBlockActionsGetter(block) is { } beginBlockActions && | |||
if (_policyActionsGetterCollection.BeginBlockActionsGetter(block) is { } beginBlockActions && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems too long... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about shortening the name?
For example
BeginBlockActionsGetter
-> BeginActions
_policyActionsGetterCollection
-> _policyActions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify meanings of each variable, I decided to insert newline instead of shortening variable names.
9a6d3d8
to
65a88de
Compare
Alike block actions, transaction actions are being executed at before transaction, and after transaction.