-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add CurrencyAccount
to handle all Currency
related logic
#3779
Merged
greymistcube
merged 8 commits into
planetarium:main
from
greymistcube:feature/currency-account
May 9, 2024
Merged
✨ Add CurrencyAccount
to handle all Currency
related logic
#3779
greymistcube
merged 8 commits into
planetarium:main
from
greymistcube:feature/currency-account
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymistcube
force-pushed
the
feature/currency-account
branch
2 times, most recently
from
May 8, 2024 06:56
8aecb53
to
3fd7917
Compare
greymistcube
force-pushed
the
feature/currency-account
branch
from
May 8, 2024 06:58
3fd7917
to
b1433c9
Compare
greymistcube
changed the title
Feature/currency account
✨ Add May 8, 2024
CurrencyAccount
to handle all Currency
related logic
s2quake
reviewed
May 9, 2024
s2quake
reviewed
May 9, 2024
greymistcube
force-pushed
the
feature/currency-account
branch
from
May 9, 2024 05:22
b9dfa37
to
a9f98b3
Compare
Migration is mostly covered by |
I've added an additional test regarding migration. See 4e5fc2f. |
OnedgeLee
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is pretty convoluted at the moment. 🙄
There are numerous issues regarding
Currency
:Currency
.Currency
manipulation pipeline is running on top of the assumption that a state is "consistent"Currency
:TotalSupply
does not exceedMaximumSupply
TotalSupply
is being tracked and is correct.TotalSupplyTrackable
loses its meaning starting withBlockMetadata.CurrencyAccountProtocolVersion
.Exception
forTotalSupply
.Exception
regardingTotalSupply
must be handled fromIAction
side (or any outside service), and its interpretation requires additional knowledge aboutCurrency
and the behavior of read operation ofTotalSupply
.MintAsset()
orBurnAsset()
should be preceded by authority validation.IAction
s.This is partially due to information about
Currency
not being recorded in a state and migration toCurrencyAccount
modeldoes not permit adding in this missing information.
I'll be making some
Currency
spec and API changes in separate PRs to mitigate some of these issues. 😶