Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move files to the following paths: src, test, tools #3828

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

s2quake
Copy link
Contributor

@s2quake s2quake commented Jun 18, 2024

All projects within Libplanet.sln will move to the path shown below.

src

  • Libplanet
  • Libplanet.Action
  • Libplanet.Common
  • Libplanet.Crypto.Secp256k1
  • Libplanet.Crypto
  • Libplanet.Net
  • Libplanet.RocksDBStore
  • Libplanet.Store.Remote
  • Libplanet.Store
  • Libplanet.Stun
  • Libplanet.Types

test

  • Libplanet.Action.Tests
  • Libplanet.Analyzers.Tests
  • Libplanet.Crypto.Secp256k1.Tests
  • Libplanet.Explorer.Cocona.Tests
  • Libplanet.Explorer.Tests
  • Libplanet.Extensions.Cocona.Tests
  • Libplanet.Mocks
  • Libplanet.Net.Tests
  • Libplanet.RocksDBStore.Tests
  • Libplanet.Store.Remote.Tests
  • Libplanet.Stun.Tests
  • Libplanet.Tests

tools

  • Libplanet.Analyzers
  • Libplanet.Benchmarks
  • Libplanet.Explorer.Cocona
  • Libplanet.Explorer.Executable
  • Libplanet.Explorer
  • Libplanet.Extensions.Cocona
  • Libplanet.Tools

@s2quake s2quake changed the title Move files to the following paths: Src, test, tools Move files to the following paths: src, test, tools Jun 18, 2024
@s2quake s2quake force-pushed the chore/move-path branch 11 times, most recently from 8f07e55 to 09c9980 Compare June 18, 2024 03:54
@s2quake s2quake added the no changelog Bypasses changelog check label Jun 18, 2024
@s2quake s2quake force-pushed the chore/move-path branch 7 times, most recently from dc5cdf0 to bace92a Compare June 18, 2024 07:30
@s2quake s2quake changed the title Move files to the following paths: src, test, tools Refactor: Move files to the following paths: src, test, tools Jun 18, 2024
@s2quake s2quake self-assigned this Jun 18, 2024
@s2quake s2quake force-pushed the chore/move-path branch 2 times, most recently from 4a8eb14 to 65845c5 Compare June 18, 2024 07:36
@s2quake s2quake marked this pull request as ready for review June 18, 2024 08:08
@riemannulus
Copy link
Member

Can we move it like this and move it later if needed?

@riemannulus riemannulus mentioned this pull request Jun 19, 2024
8 tasks
@s2quake
Copy link
Contributor Author

s2quake commented Jun 20, 2024

Can we move it like this and move it later if needed?

Simply moving a project to a different path isn't difficult, but it's a little tricky because the project path (specifically Libplanet.Tools) affects ci operations.
I think it's relatively easy, except for the two things below.

  • Rename src, test, tools.
  • Change the location of Libplanet.Tools to something else.

@riemannulus
Copy link
Member

Ok, merge after checking which has a dependency on libplanet.

@s2quake s2quake force-pushed the chore/move-path branch 3 times, most recently from 3d6ba2e to e4da613 Compare June 21, 2024 04:43
riemannulus
riemannulus previously approved these changes Jun 24, 2024
limebell
limebell previously approved these changes Jun 24, 2024
Copy link
Member

@limebell limebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update PR to main branch :)

OnedgeLee
OnedgeLee previously approved these changes Jun 24, 2024
@s2quake s2quake dismissed stale reviews from OnedgeLee, limebell, and riemannulus via 4f65151 June 25, 2024 00:34
@s2quake s2quake force-pushed the chore/move-path branch 2 times, most recently from 4f65151 to 75ac84b Compare June 25, 2024 00:50
greymistcube
greymistcube previously approved these changes Jun 25, 2024
@s2quake s2quake merged commit 901ecb2 into planetarium:main Jun 25, 2024
22 checks passed
@s2quake s2quake deleted the chore/move-path branch June 25, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Bypasses changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants