-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ProposeGenesis in TestUtils to remove redundant Initialize() #3972
Conversation
Please rebase. Congratulations on your first contribution to the Libplanet! |
5d627e4
to
39ddd67
Compare
Hi @Atralupus, I rebase based on the latest changes in main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you 💯
39ddd67
to
47e79c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes affect genesis block, and changes on genesis block hash will change the order of transactions on test.
So, test/Libplanet.Tests/TestUtils.cs need to be modified like below.
(1, 0, new[] { "A", "B", "C", "E", null }, _txFx.Address2),
(0, 0, new[] { "A,D", "B", "C", "E", null }, _txFx.Address1),
(2, 0, new[] { "A,D", "B", "C", "E", "F" }, _txFx.Address3),
Please check this commit!
Hi @OnedgeLee, I am not sure what you want me to update. |
I've added a commit for test fixture update. |
This Fixes: #3781
The code I updated
to