Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Newline] Possible regression bug (due to new newline management)? #2094

Closed
The-Lum opened this issue Feb 24, 2025 · 4 comments
Closed

[Newline] Possible regression bug (due to new newline management)? #2094

The-Lum opened this issue Feb 24, 2025 · 4 comments
Milestone

Comments

@The-Lum
Copy link
Collaborator

The-Lum commented Feb 24, 2025

Context

To follow:

Bug observed

  • It seems there is a regression bug (due to new newline management)?

See all explanation of @kirchsth here:

Minimal not working example

New version

@startuml
!include <C4/C4_Container.puml>

AddBoundaryTag("v1", $bgColor="lightgreen", $fontColor="green", $borderColor="green")

System_Boundary(c1, "Internet Banking", $tags="v1") {
}
@enduml

See preproc output...

Versus old version (tested on V 1.2024.8)

Regards,
Th.

@The-Lum The-Lum removed the triage label Feb 24, 2025
@arnaudroques
Copy link
Contributor

Thanks for the minimal example, but unfortunately, it's not really minimal :-)

The !include <C4/C4_Container.puml> imports a lot of things, it would be nice to have an example without any !include.

From what I'm understanding, the !include builds some dynamic skinparam, but I am getting lost in the different function calls...

@The-Lum
Copy link
Collaborator Author

The-Lum commented Feb 24, 2025

Hello all,

@kirchsth have you a more minimal example?

Otherwise just to see the new newline char, here is some hints:

@startuml
!include <C4/C4.puml>

AddBoundaryTag("v1", $bgColor="lightgreen", $fontColor="green", $borderColor="green")

System_Boundary(c1, "Internet Banking", $tags="v1") {
}
@enduml

Link

skinparam rectangle<<v1_boundary>> {↵ FontColor green↵ BackgroundColor lightgreen↵ BorderColor green↵}↵skinpara ...

Where you can see char...

Regards,
Th.

@The-Lum
Copy link
Collaborator Author

The-Lum commented Feb 24, 2025

Can't see where the bug comes from.. but at least there is a bug on the preproc...

I open an issue about the prerpoc...

@kirchsth
Copy link
Contributor

Thank you @arnaudroques and @The-Lum for the fast fix and the detailed analysis.
I tried it with with then new v1.2025.2beta3 and the color is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants