[WIP] make nodes collapsable #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using this Feature |
orangecms
reviewed
Jan 27, 2024
There was a problem hiding this comment.
Suggestion:
We have the tree in the state and derive the layout from it.
When collapsing a node, it would be nice to redistribute the nodes accordingly.
So let's hoist the collapsed state from being local here to bring global, and treat a collapsed node just like a leaf. The current transform helpers may need some splitting in order to accomodatr for that. WDYT?
|
So, I thought about the whole case and my next steps would be:
What do you think about hiding the nodes starting on the 3rd level by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea:
A node has a link or button to hide child nodes. The button changes from "[-]" to "[+]" to inform the user