Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't detect gradle syntax errors #85

Closed
ignasi35 opened this issue Jan 8, 2019 · 4 comments
Closed

CI doesn't detect gradle syntax errors #85

ignasi35 opened this issue Jan 8, 2019 · 4 comments

Comments

@ignasi35
Copy link
Member

ignasi35 commented Jan 8, 2019

As reported in #74, #81, #72, ... some of the g8 template files use $ and templatecontrol messe them up breaking the g8 templating syntax.

The CI build in this repo doesn't detect this issue.

Related: foundweekends/giter8#408 and foundweekends/giter8#334

@TimMoore
Copy link

TimMoore commented Jan 9, 2019

There is a gradle test, but it is configured as an allowed failure:
https://travis-ci.org/playframework/play-scala-seed.g8/builds/475599011

Looks like it was introduced here:
b28045a#diff-354f30a63fb0907d4ad57269548329e3R24

    # Current release of Gradle still does not supports Play 2.7.x releases
    # As soon as there is a release of Gradle that fixes that, we can then
    # remove this allowed failure.

@marcospereira it sounds like it should be safe to configure the 2.6.x branch to require this to pass, correct?

Looks like the underlying problem was fixed here: playframework/templatecontrol#85

@TimMoore
Copy link

TimMoore commented Jan 9, 2019

Actually, this problem affects any use of sbt new, not just for Gradle users.

The problem is detected in the normal build, too, but does not cause the build to fail:
https://travis-ci.org/playframework/play-scala-seed.g8/jobs/475599012#L678

Falling back to file copy for /home/travis/build/playframework/play-scala-seed.g8/src/main/g8/build.gradle: File: /home/travis/build/playframework/play-scala-seed.g8/src/main/g8/build.gradle, 59:71: mismatched input '.' expecting LPAREN

The message is slightly different from what's reported by users, and looks like it's just a warning with fallback behavior. Maybe it depends on the sbt version used?

@TimMoore
Copy link

TimMoore commented Jan 9, 2019

Related discussion: akka/akka-http-quickstart-scala.g8#15

@mkurz
Copy link
Member

mkurz commented Mar 2, 2023

Gradle support has been dropped from this repo #119 therefore closing this issue.
However, meanwhile gradle does actually support Play 2.8, so if someone wants to it back here feel free to add a PR.

@mkurz mkurz closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants