Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No log output when message cannot be parsed #2

Open
skyluc opened this issue Aug 14, 2017 · 1 comment
Open

No log output when message cannot be parsed #2

skyluc opened this issue Aug 14, 2017 · 1 comment

Comments

@skyluc
Copy link

skyluc commented Aug 14, 2017

When sending a message which cannot be decoded, like because of a typo in the Json message, the message fails to be processed without any error message in the log.

I was expecting some error.

After fixing the typo, my application worked as expected.

@jroper
Copy link
Member

jroper commented Aug 23, 2017

Was an error sent to the client? You should get an error on the client (handled by attaching an error handler to the namespace), I'm not exactly sure how descriptive it will be though, there may be an opportunity to improve it.

Not sure what the best way to approach this is, generally a web server doesn't log parsing errors to its logs, instead it returns errors to the client because really it's the clients problem, not the servers, and the internet is full of bots and third party services throwing all sorts of junk at web servers, logging these errors doesn't usually serve any useful purpose other than creating a lot of noise in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants