Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize copy/client.ImageExistsAtRemote calls #72

Open
aslafy-z opened this issue Mar 31, 2023 · 1 comment · May be fixed by #73
Open

Parallelize copy/client.ImageExistsAtRemote calls #72

aslafy-z opened this issue Mar 31, 2023 · 1 comment · May be fixed by #73
Labels
enhancement New feature or request

Comments

@aslafy-z
Copy link

aslafy-z commented Mar 31, 2023 •
edited
Loading

When working with a big list of images, getting the remote manifests synchronously can take minutes.
I believe this can easily be parallelized to get some better results.

This is the synchroneous loop that takes time https://github.com/plexsystems/sinker/blob/main/internal/commands/copy.go#L84
@aslafy-z aslafy-z changed the title Parallelize copy/remote.Get calls Parallelize copy/client.ImageExistsAtRemote calls Mar 31, 2023
@jpreese jpreese added the enhancement New feature or request label Mar 31, 2023
@jpreese
Copy link
Collaborator

jpreese commented Mar 31, 2023

This makes sense to me!

@aslafy-z aslafy-z linked a pull request Apr 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: parallelize copy/client.ImageExistsAtRemote calls aslafy-z/sinker
2 participants
@jpreese @aslafy-z