-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-ons installed as editable are not found anymore #4127
Comments
Problem has been originally reported on training setup |
Related: #4126. This is hitting Plone hard.
Basically we need to stop using |
The main technical issue is in plone.autoinclude, which Steve already linked above. I have first fixed the test setup today, as GitHub Actions had already been failing since at least earlier this year. See plone/plone.autoinclude#27 which has been merged. Warning: this drops support for Plone 5.2 and for Python 3.8. Also, PyPy and Buildout 2 and 3 are not tested anymore, though they might still work. And then we need an actual fix of the problem. There are currently three candidate PRs:
That last one is mine, and it is the only green one. So I recommend it. :-) Meanwhile, I mention some workarounds on community.plone.org. Some other workarounds are above it. Lastly: yes, we should replace all usage of |
Notes from my study of this problem today: setuptools 75.8.1 was released yesterday. It changed the filename that is produced when an sdist is built into a wheel to match the standard from PEP 491. Now a period in the package name is turned into an underscore in the distribution name. This caused at least two problems: A. plone.autoinclude tries to find a package matching the name of the distribution where the plone entrypoint was declared. This broke since they no longer match. Important note 1: this happens when building an sdist into a wheel even if setuptools is pinned like we normally do, because the build_wheel process runs in an isolated environment that installs setuptools without the pin. (A workaround for this is to add Important note 2: Reproducing the problem locally can be complicated because if pip finds an existing wheel in its cache with the correct version, it will use it instead of building a new one. To avoid this, purge the cache with Problem B seems to have been resolved at least for now in setuptools 75.8.2 which was released today. So we don't need to stop using I tested @mauritsvanrees' solution for Problem A in plone/plone.autoinclude#30 with my project and it seems to fix the problem. We'll need a new release of plone.autoinclude with the fix, and will have to show people how to use it in older Plone releases. |
I have published Warning: this |
Thank you @mauritsvanrees ! I can confirm that the new version of plone.autoinclude fixes the problem, |
BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
What I did:
What I expect to happen:
What actually happened:
ModuleNotFoundError: No module named 'project_title'
What version of Plone/ Addons I am using:
Python 3.12
Plone 6.1, Plone 6.0
The text was updated successfully, but these errors were encountered: