Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook build fails, blocks deployment of Documentation #1847

Closed
stevepiercy opened this issue Feb 7, 2025 · 0 comments · Fixed by #1848
Closed

Storybook build fails, blocks deployment of Documentation #1847

stevepiercy opened this issue Feb 7, 2025 · 0 comments · Fixed by #1848

Comments

@stevepiercy
Copy link
Contributor

@sneridagh @davisagli for Documentation, we don't build any Storybooks for PR previews (it would be redundant to those done here in Volto), but we do build and deploy the Volto Storybook to https://6.docs.plone.org/storybook/. See:

  • documentation/Makefile

    Lines 225 to 227 in 77eb1d3

    .PHONY: storybook
    storybook:
    cd submodules/volto && pnpm i && pnpm build:registry && pnpm --filter @plone/volto build-storybook -o ../../../../_build/html/storybook
  • - name: Prepare deploy
    run: make deploy
    - name: Use Node.js ${{ env.node-version }}
    uses: actions/setup-node@v4
    with:
    node-version: ${{ env.node-version }}
    - name: Enable corepack
    shell: bash
    run: corepack enable
    - name: Get pnpm store directory
    shell: bash
    run: |
    echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
    - uses: actions/cache@v3
    name: Setup pnpm cache
    with:
    path: ${{ env.STORE_PATH }}
    key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
    restore-keys: |
    ${{ runner.os }}-pnpm-store-
    - name: StoryBook build
    run: make storybook

We need to update these files as well, per this failure to deploy documentation.

https://github.com/plone/documentation/actions/runs/13201540554/job/36854535312

Can either of you make a recommendation or PR?

Originally posted by @stevepiercy in plone/volto#6684 (comment)

@github-project-automation github-project-automation bot moved this to Needs discussion in Volto Team Meeting Feb 7, 2025
@stevepiercy stevepiercy changed the title @sneridagh @davisagli for Documentation, we don't build any Storybooks for PR previews (it would be redundant to those done here in Volto), but we do build and deploy the Volto Storybook to https://6.docs.plone.org/storybook/. See: Storybook build fails, blocks deployment of Documentation Feb 7, 2025
@stevepiercy stevepiercy moved this from New to Todo in Plone Documentation Feb 7, 2025
@stevepiercy stevepiercy moved this from Needs discussion to Plan approved in Volto Team Meeting Feb 7, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Plone Documentation Feb 7, 2025
@github-project-automation github-project-automation bot moved this from Plan approved to Done in Volto Team Meeting Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant