Logo change TTW

[avoinea]

Would be nice to be able to change to logo TTW via /controlpanel/site

[ericof]

@sneridagh This should be the default way for Volto 17.

[erral]

When we merge the @site and @navroot endpoint PR in plone.restapi, I have a PR for Volto adding this feature.

[ericof]

@erral Could you, please, link to the plone.restapi PR?

[erral]

this one plone/plone.restapi#1465

we can expose the logo through it, add the logo to the Volto controlpanel.

I have a draft PR here #3537

[tisto]

@erral @sneridagh what's the status of this? The PR has been merged. Am I able to change the logo TTW in latest Volto now?

[tisto]

@erral @sneridagh I gave this a try. This is awesome! Though, it seems that I can upload only SVG logos. Can we amend the component to work with png/jpg as well?

[erral]

are you sure about the svg thing? I have just uploaded a PNG to demo.plone.org

[tisto]

@Erreal this is odd. I just tried again and now a png works.

[davisagli]

@tisto Does it depend on the size of the image? There was a change in Zope to use a new library for parsing requests (because the cgi module was removed from recent versions of Python). As a result, we can hit a limit on memory use while parsing files encoded in a JSON body, like the REST API uses. So I wonder if that's what you ran into before. To solve it, I think we need to add support for a new format for file uploads in the REST API, where file fields can reference an attachment from a separate multipart/form-data part.

[tkimnguyen]

Should we close this issue? It is now possible to change the logo TTW. (Though, as discussed in https://community.plone.org/t/bug-in-changing-site-logo-volto/20430 it is buggy)

We could create new issues for some of the related things you came up with.

[tkimnguyen]

OK I'll be bold and close it, since the above discussion is over a year old now.

[stevepiercy]

@tkimnguyen please don't close an issue that has an unresolved matter. @davisagli's comment suggests that we need to create an issue in plone.restapi and potentially change how Volto handles file uploads. Reopening.

See possibly related issue plone/plone.restapi#1730.

[davisagli]

@stevepiercy My comment about the upload limit was just me hypothesizing about what the cause of Timo's problem might have been; it wasn't a diagnosis. There's already a workaround in place for that limit (plone/plone.restapi#1729) and we have plone/plone.restapi#1730 for working on a more permanent solution. I'll close this issue since we have other issues covering the outstanding problems.