Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled mode doesn't recognize incompatible objects inside abstractions #2061

Open
dromer opened this issue Feb 3, 2025 · 4 comments
Open

Comments

@dromer
Copy link
Contributor

dromer commented Feb 3, 2025

We regularly get users that are confused as to why their patches don't work.
The cause is nearly always that they use some abstraction that uses incompatible objects under the hood.

It would be nice if the "compiled mode" check can traverse abstractions to properly raise the expected warnings.
Perhaps it should then mark the entire abstraction as incompatible (ie. make it orange).

@timothyschoen
Copy link
Collaborator

Does b09bdbd help?

@dromer
Copy link
Contributor Author

dromer commented Feb 15, 2025

Hmm no, I see that for instance above abstraction from else is recognized as unsupported, but its contents are totally heavy compatible actually:

Image

@dromer
Copy link
Contributor Author

dromer commented Feb 15, 2025

And indeed my own heavy compatible abstractions all show as unsupported now:

Image

@timothyschoen
Copy link
Collaborator

Ah, I see. I'll roll this back and work on a better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants