Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatmullRomLine segments prop is not working #1476

Closed
martini-airsquire opened this issue May 29, 2023 · 0 comments · Fixed by #2362
Closed

CatmullRomLine segments prop is not working #1476

martini-airsquire opened this issue May 29, 2023 · 0 comments · Fixed by #2362
Labels
bug Something isn't working

Comments

@martini-airsquire
Copy link

  • three version: 0.150.1
  • @react-three/fiber version: 8.12.0
  • @react-three/drei version: >=9.53.0
  • node version: 18.0.0
  • npm (or yarn) version: 9.2.0

Problem description:

I need to specify the segments prop on <CatmullRomLine />, but the segments props CatmullRomLine conflict with the segments prop in LineProps, and can only be set to undefined right now

Relevant code:

<CatmullRomLine points={points} segments={points.length - 1} />

Suggested solution:

Suggest rename newly added segments prop in LineProps (9.53.0) to something else, so both segments props can exist without conflict

@martini-airsquire martini-airsquire added the bug Something isn't working label May 29, 2023
@github-actions github-actions bot added the Stale Inactive issue label Oct 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
@CodyJasonBennett CodyJasonBennett removed the Stale Inactive issue label Feb 22, 2025
@pmndrs pmndrs deleted a comment from github-actions bot Feb 22, 2025
@pmndrs pmndrs deleted a comment from github-actions bot Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants