Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pop-up displaying network requests does not appear in Release 2.0.0 when a modal view or controller is already presented. #145

Open
Silviuvr opened this issue Dec 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Silviuvr
Copy link

The network request pop-up does not appear when a modal view, such as a login bottom sheet, is presented. For example, if I present the login bottom sheet and shake the phone, the pop-up with active requests is not displayed.

However, after completing the login process and dismissing the bottom sheet, the pop-up works as expected on the main dashboard page.

This behavior suggests the pop-up is not functioning correctly when a modal view is active.

@pmusolino pmusolino added the bug Something isn't working label Jan 30, 2025
@robnadin
Copy link

robnadin commented Feb 4, 2025

This appears to be a regression. The old version had code to determine the current (top-most) view controller, but in 2.0.0 and later it is simply just trying to present on the root view of the window, regardless of whether that view is already presenting a sheet/modal view itself.

@akovalov
Copy link

Indeed, 2.0.0 allows presenting the view controller only via a notification. Internal function presentWormholyFlow() presents on UIApplication.shared.windows.first?.rootViewController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants