Markdown output title contains undefined

[milanholemans]

Was checking a PR in different outputs. Noticed that we get an undefined in the table header

Is this on purpose? Or should we fix it? To me it seems not ideal to print an undefined

@pnp/cli-for-microsoft-365-maintainers

[waldekmastykarz]

We use a few known properties to extract the title from. If the object doesn't use any of them, we print undefined. This is how we designed the md output initially. If we think we should change it, let's propose alternatives 👍

[milanholemans]

Got another markdown output for another PR

Are we going to keep it like this? To me it seems like something went wrong.

[milanholemans]

That looks good to me 👍

[Adam-it]

sorry for maybe a stupid question (reply 😉). As I had nothing interesting to add I didn't add any value here but tried to keep up but TBH in the last post I got a bit lost😅
by ## custom rendering if neither title nor id are present.
you mean we should override md rendering for this specific command or any other command that's a special case right? So with additional logic for this output mode in the command file code?

[milanholemans]

you mean we should override md rendering for this specific command or any other command that's a special case right? So with additional logic for this output mode in the command file code?

Yes, few commands will output a header like ## undefined (undefined) now which is not ideal. I think that Waldek indeed meant to override this output in the command file itself.

[Adam-it]

@milanholemans for clarifying this 😊
cool. I like the idea and agree on it all 👍
@milanholemans, @waldekmastykarz, @Jwaegebaert awesome concept work on figuring this our 💪. You all rock 🤩

[waldekmastykarz]

I created issue #4380 to track the work needed to update the generic md output rendering. Additionally, we should make a list of commands that require custom rendering and create an issue to track updating them.