-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete example #6272
Comments
Shall I do this, @milanholemans? |
Sure! Thanks. |
@tmaestrini did you find some time create a PR for this? |
@milanholemans Sorry, but I've done something dumb. As my last PR #6250 is still open (and I haven't noticed), I've caused a mess. Sorry for that. Therefore, I've closed the PR #6366 immediately after having opened it. How do I have to move on? |
When creating a PR, we always encourage people to create a new branch in their fork repo. This way, you can work on different issues without them interfering with each other. |
So, would it be fine with you that I'll open the PR immediately after having closed #6250 (because I have already merged the changes into the main branch of my fork)? |
hi @tmaestrini , If you want to participate and make this PR count towards this event please be sure to open the PR in October (no sooner and no later 😉) |
Hey @Adam-it, I'm down! 😍😍😍 |
Hi @tmaestrini, we are prioritizing v10 issues since we want to release v10 at the end of October. Could you already start working on this PR? To get around the issue of your edits to your main branch, please execute the code below to create a new branch from our current v10.
Next time you create a PR, we advice you to create a new branch for every issue you are working on and leave your main branch untouced. |
Thank you very much. I will do so (as I normally always do). 👍 I'll have a few days off next week, but I'll start cleaning up this little part of the doc immediately after my recreation time. |
Ideally, we'd like to have all v10 PRs closed in week 43. So you still have some time. |
Kudos to @tmaestrini
Seems like we forgot to remove an obsolete example in our V9 branch. In the aftermath of #5558, we should also remove the last example from the docs.
The text was updated successfully, but these errors were encountered: