Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete example #6272

Closed
milanholemans opened this issue Aug 25, 2024 · 11 comments
Closed

Remove obsolete example #6272

milanholemans opened this issue Aug 25, 2024 · 11 comments
Assignees
Milestone

Comments

@milanholemans
Copy link
Contributor

Kudos to @tmaestrini

Seems like we forgot to remove an obsolete example in our V9 branch. In the aftermath of #5558, we should also remove the last example from the docs.

image

@tmaestrini
Copy link

Shall I do this, @milanholemans?

@milanholemans
Copy link
Contributor Author

Sure! Thanks.

@milanholemans
Copy link
Contributor Author

@tmaestrini did you find some time create a PR for this?

@tmaestrini
Copy link

tmaestrini commented Sep 18, 2024

@milanholemans Sorry, but I've done something dumb. As my last PR #6250 is still open (and I haven't noticed), I've caused a mess. Sorry for that. Therefore, I've closed the PR #6366 immediately after having opened it.

How do I have to move on?

@milanholemans
Copy link
Contributor Author

When creating a PR, we always encourage people to create a new branch in their fork repo. This way, you can work on different issues without them interfering with each other.

@tmaestrini
Copy link

tmaestrini commented Sep 19, 2024

So, would it be fine with you that I'll open the PR immediately after having closed #6250 (because I have already merged the changes into the main branch of my fork)?

@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Sep 24, 2024

hi @tmaestrini ,
This issue will take part in the Hacktoberfest event which will take part during October.
You may read more about this event here:
#6383

If you want to participate and make this PR count towards this event please be sure to open the PR in October (no sooner and no later 😉)

@tmaestrini
Copy link

Hey @Adam-it, I'm down! 😍😍😍

@milanholemans
Copy link
Contributor Author

milanholemans commented Sep 28, 2024

So, would it be fine with you that I'll open the PR immediately after having closed #6250 (because I have already merged the changes into the main branch of my fork)?

Hi @tmaestrini, we are prioritizing v10 issues since we want to release v10 at the end of October. Could you already start working on this PR? To get around the issue of your edits to your main branch, please execute the code below to create a new branch from our current v10.

git remote add upstream https://github.com/pnp/cli-microsoft365.git
git fetch upstream
git checkout -b fix-example upstream/main

Next time you create a PR, we advice you to create a new branch for every issue you are working on and leave your main branch untouced.

@tmaestrini
Copy link

Thank you very much. I will do so (as I normally always do). 👍

I'll have a few days off next week, but I'll start cleaning up this little part of the doc immediately after my recreation time.

@milanholemans
Copy link
Contributor Author

Ideally, we'd like to have all v10 PRs closed in week 43. So you still have some time.

ktskumar pushed a commit to ktskumar/cli-microsoft365 that referenced this issue Oct 16, 2024
tmaestrini pushed a commit to tmaestrini/cli-microsoft365 that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants