Adds spp autofillcolumn apply command. Closes #6203 #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkm17
force-pushed
the
issues/6203_spp_autofillcolumn-apply
branch
from
2ff3284
to
50c5529
Compare
|
Thank you, we'll try to review it ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spp autofillcolumn apply command. Closes #6203
Hi, just a few remarks on this command:
I’ve added the
columnIdandcolumnTitleparameters to allow selection of the column by either option.I noticed that retrieving the list instance, like in the
getDocumentLibraryInfofunction, appears in several places in the solution. Could you advise on where we should store this common code? Is spo.ts the correct file for it?Similarly, for retrieving a field, should the
getColumnfunction also be placed in spo.ts?Do you think I should make these updates in this PR, or would it be better to create a separate one?