Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/Enable Dynamic form based on property does not work as expected #1856

Open
KwernH opened this issue Aug 1, 2024 · 4 comments
Open

Comments

@KwernH
Copy link

KwernH commented Aug 1, 2024

[ ] Enhancement

[ ] Bug
Disable/enable Dynamic form does not work as expected when I pass the value as props.

[ ] Question

Version

Please specify what version of the library you are using: [
"@pnp/spfx-controls-react": "3.18.1",
"@pnp/spfx-property-controls": "3.17.1", ]

Expected / Desired Behavior / Question

I have a dialog component which have a dynamic form there:
Dynamic form

I am trying to use the "Edit" button to edit the value of this.props.viewModel. The value does get updated.(See the picture as below.)
debug dynamic form

I am expecting the dynamic form should be editable. But it does not get refreshed, all fields are still disabled. Could you please help to check and suggest if there's any way around?

Copy link

github-actions bot commented Aug 1, 2024

Thank you for submitting your first issue to this project.

@KwernH
Copy link
Author

KwernH commented Aug 6, 2024

Anyone can help on this?

@Haiqi-Wu
Copy link

Haiqi-Wu commented Aug 9, 2024

Try to update this value in parent component state.

@KwernH
Copy link
Author

KwernH commented Aug 16, 2024

Try to update this value in parent component state.

Thanks for replying, but if you see my screenshot, the value comes from it's parent component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants